From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6A1DCF9C7A for ; Wed, 25 Sep 2024 15:06:56 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0AED484A; Wed, 25 Sep 2024 17:06:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0AED484A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1727276815; bh=oUEDKfr3g2+OPN66lqRdCh/RebgOM2ORzt3yS88puJc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=JwxV+k/H1dLNmwCVCJugYTXuZihW6O1jGmsDpZmj+8P9a7p7Alh6ht64MuKJXKfL2 kX+kJPDZbTL1CCS4DNCc4gvOXjI8nCO6PgqOpc+nba2tFyCwhlkKTWQs5fvnbqfKxB usejHa0l1wN6be4r6AV1cEsiO8Glak0gTzNtAQ4E= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 78680F80637; Wed, 25 Sep 2024 17:05:38 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2F642F8063D; Wed, 25 Sep 2024 17:05:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id ED3C3F80632; Wed, 25 Sep 2024 17:05:33 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C8D39F80633 for ; Wed, 25 Sep 2024 17:05:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C8D39F80633 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Ma5zlO1I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727276733; x=1758812733; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oUEDKfr3g2+OPN66lqRdCh/RebgOM2ORzt3yS88puJc=; b=Ma5zlO1IdYSn9+wbCwqaLuTP/MbvIbjo9S+QNwLPV27X/CmwPY/iXv/C DJJJgxHvx/q8YbW4Und12Un4BfwMBVD8RdznaQuArOpabUNTqx/s4xWp8 cVQKNCeuCd7uZREeiAy1EJVfEsVWP8J1KFjrXg5rzcwcOglweEQ3gWEwk 6YoRkynk8l2xFYgzoN45zOFWdsI0/J8rkQxWbCavcqy37e3fiS46b8LId Y3GPkdYgFJ4Bfku32xJax/B4xvT2YGPtgdCQubeT+tH1JTxNg8RBwz2Sz nLzG9Bz1SFOOTElLYO2SaGv0TZChpjTtT0VqTtfhy3/G8qs9dFD57iuxT g==; X-CSE-ConnectionGUID: vJY6GeEfSKOhSJa/HT1AkQ== X-CSE-MsgGUID: wgJZ4PR1S1W3eIvorpfWVA== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="26482982" X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="26482982" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2024 08:05:31 -0700 X-CSE-ConnectionGUID: UJBsXjh0QG6gd/Q+NIpkLw== X-CSE-MsgGUID: Q21AA1FjTgeEkddoyjPTvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,257,1719903600"; d="scan'208";a="76317772" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO [10.245.246.30]) ([10.245.246.30]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2024 08:05:26 -0700 Message-ID: <4552c7fb-2c59-485d-af67-0bf36d2424e5@linux.intel.com> Date: Wed, 25 Sep 2024 17:04:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v28 00/32] Introduce QC USB SND audio offloading support To: Wesley Cheng , srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, conor+dt@kernel.org, dmitry.torokhov@gmail.com, corbet@lwn.net, broonie@kernel.org, lgirdwood@gmail.com, tiwai@suse.com, krzk+dt@kernel.org, Thinh.Nguyen@synopsys.com, bgoswami@quicinc.com, robh@kernel.org, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, alsa-devel@alsa-project.org References: <20240925010000.2231406-1-quic_wcheng@quicinc.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: <20240925010000.2231406-1-quic_wcheng@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: 4A4XTS5BMAM2DZ3MIA3FFFJXXHSJHF23 X-Message-ID-Hash: 4A4XTS5BMAM2DZ3MIA3FFFJXXHSJHF23 X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Overall the patchset is much improved but you still have misleading information, see e.g. the rather poor description of error codes for the update_offload_route() helper. I hope other reviewers step-in to cover this large set of patches... Cheers, -Pierre