From: Daniel Drake <dsd@gentoo.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, perex@suse.cz
Subject: Re: [PATCH] hda_codec: restore control element values during resume
Date: Wed, 02 May 2007 11:57:00 -0400 [thread overview]
Message-ID: <4638B4CC.4060606@gentoo.org> (raw)
In-Reply-To: <s5htzuvbkww.wl%tiwai@suse.de>
Takashi Iwai wrote:
> The controls should have been restored by snd_hda_resume_ctls() call
> in stac92xx_resume(), so basically your patch must be suprefluous.
> Could you check whether this gets called?
I did see the snd_hda_resume_ctls() code but noted it was resuming from
snd_kcontrol_new structures rather than snd_kcontrol instances. I'm
still not sure what the difference is here, are they supposed to
'mirror' each other?
Anyway, it turns out that snd_hda_resume_ctls() doesn't get executed.
stac92xx_resume() has this code:
for (i = 0; i < spec->num_mixers; i++)
snd_hda_resume_ctls(codec, spec->mixers[i]);
On my system, spec->num_mixers is 0.
Daniel
next prev parent reply other threads:[~2007-05-02 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-29 16:14 [PATCH] hda_codec: restore control element values during resume Daniel Drake
2007-05-02 10:05 ` Takashi Iwai
2007-05-02 15:57 ` Daniel Drake [this message]
2007-05-03 10:38 ` Takashi Iwai
2007-05-06 0:09 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4638B4CC.4060606@gentoo.org \
--to=dsd@gentoo.org \
--cc=alsa-devel@alsa-project.org \
--cc=perex@suse.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox