alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Steve Longerbeam <stevel@embeddedalley.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@suse.cz>
Subject: Re: [PATCH] Add support for gain in softvol plugin
Date: Thu, 17 May 2007 15:00:35 -0700	[thread overview]
Message-ID: <464CD083.6090306@embeddedalley.com> (raw)
In-Reply-To: <4648BA6B.3020101@embeddedalley.com>

Steve Longerbeam wrote:
> Takashi Iwai wrote:
>   
>> At Thu, 10 May 2007 12:57:10 -0700,
>> Steve Longerbeam wrote:
>>   
>>     
>>> Hi Takashi,
>>>
>>> Thanks, that's much better. I tried doing that myself a while ago, but I 
>>> must have been doing something wrong because the capture device wasn't 
>>> being recognized. But your version works.
>>>
>>> Version 4 of the patch is attached. It's much better, only two modified 
>>> files: pcm_softvol.c and HDA-Intel.conf.
>>>
>>> I also reduced the gain range, it's now -30 to +30 dB.
>>>     
>>>       
>> I'm afraid that this choice would be bad for the current TLV
>> representation.  The default resolution is 256, so -30/30 dB range
>> doesn't match to this resolution.  We should change either resolution
>> (e.g. 120, corresponding to 0.5dB step), or the range.
>>   
>>     
>
> ok, that's no problem. How about we change the range to (in HDA-Intel.conf):
>
> min_dB: -21.0
> max_dB: 30.0
>
>
>   

Hi Takashi, should I send another patch with this change?

Steve

>> Otherwise it looks fine to me.
>>
>>
>> Thanks,
>>
>> Takashi
>>
>>   
>>     
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
>   

  reply	other threads:[~2007-05-17 22:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-03 19:11 [PATCH] Add support for gain in softvol plugin Steve Longerbeam
2007-05-03 19:22 ` Jaroslav Kysela
2007-05-03 22:24   ` Steve Longerbeam
2007-05-04  7:40     ` Jaroslav Kysela
2007-05-04 16:27       ` Steve Longerbeam
2007-05-04 17:33         ` Steve Longerbeam
2007-05-09 12:46           ` Takashi Iwai
2007-05-10 19:57             ` Steve Longerbeam
2007-05-14  9:26               ` Takashi Iwai
2007-05-14 19:37                 ` Steve Longerbeam
2007-05-17 22:00                   ` Steve Longerbeam [this message]
2007-05-18 13:05                     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464CD083.6090306@embeddedalley.com \
    --to=stevel@embeddedalley.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@suse.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).