Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: alsa-devel@alsa-project.org
Subject: hw_params function and OSS emulation
Date: Tue, 21 Aug 2007 13:15:16 -0500	[thread overview]
Message-ID: <46CB2BB4.9060808@freescale.com> (raw)

I'm working on an ASoC driver, and I noticed that with OSS emulation enabled, 
my snd_pcm_ops.hw_params and and snd_pcm_ops.hw_free are called multiple times 
when an OSS driver uses the OSS emulation.  In my case, .hw_params is called 
*four* times, each time with a different DMA buffer size and number of periods.

The problem is that my driver allocates a DMA buffer in my .hw_params 
function.  For now, I have it deallocate the buffers at the top of the 
function and then allocate new ones based on the new hw_params values.

This is really annoying.  So I have a few questions:

1) Is there any way this can be fixed?  Can't the OSS emulation code figure 
out what it needs and wait until it's done before it calls .hw_params?

As a solution to the DMA buffer deallocate/reallocate hack I'm using, would it 
be okay to move the actual allocations to snd_pcm_ops.prepare()?  My 
.hw_params function will collect the relevant data and keep them in some 
private structure.  Then when .prepare() is called, I do the actual buffer 
allocation.

2) Can I assume that .prepare() is called only once?

3) Can I assume that .hw_params() is never called after .prepare() is called?

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

             reply	other threads:[~2007-08-21 18:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-21 18:15 Timur Tabi [this message]
2007-08-21 23:42 ` hw_params function and OSS emulation Trent Piepho
2007-08-22  9:17 ` Takashi Iwai
2007-08-22 14:28   ` Timur Tabi
2007-08-22 14:59     ` Takashi Iwai
2007-08-22 15:02       ` Timur Tabi
2007-08-22 15:39         ` Takashi Iwai
2007-08-22 15:48           ` Timur Tabi
2007-08-22 15:57             ` Takashi Iwai
2007-08-23 17:36               ` Timur Tabi
2007-08-23 17:40                 ` Takashi Iwai
2007-08-23 18:43                   ` Timur Tabi
2007-08-23 19:01                     ` Takashi Iwai
2007-08-23 19:13                       ` Timur Tabi
2007-08-23 19:35                         ` Takashi Iwai
2007-08-23 22:17                       ` Trent Piepho
2007-08-22 20:25       ` Trent Piepho
2007-08-22 21:05         ` Takashi Iwai
2007-08-22 21:08           ` Timur Tabi
2007-08-22 21:57             ` Takashi Iwai
2007-08-22 22:08               ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46CB2BB4.9060808@freescale.com \
    --to=timur@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox