Re: [PATCH] sscape: support for audio part of VIVO cards

[Rene Herman <rene.herman@gmail.com>]

On 09/17/2007 03:58 PM, Krzysztof Helt wrote:

> On Mon, 17 Sep 2007 14:30:22 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
> 
>> At Sun, 16 Sep 2007 22:50:24 +0200,
>> Krzysztof Helt wrote:
>>> @@ -358,6 +360,8 @@ static void soundscape_free(struct snd_c
>>>  {
>>>  	register struct soundscape *sscape = get_card_soundscape(c);
>>>  	release_and_free_resource(sscape->io_res);
>>> +	if (sscape->wss_res)
>>> +		release_and_free_resource(sscape->wss_res);
>> You don't need NULL check here.
>>
> 
> I need it as the SS PnP does not request a separate region for codec 
> (wss_port). So the SS PnP do not allocate this resource and it must not
> be freed.

release_and_free-resource() checks for NULL itself, by design.

Rene.