From: Rene Herman <rene.herman@gmail.com>
To: Rene Herman <rene.herman@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Krzysztof Helt <krzysztof.h1@gmail.com>,
ALSA devel <alsa-devel@alsa-project.org>,
Trent Piepho <xyzzy@speakeasy.org>
Subject: [PATCH 3/4] alsa-kernel: schedule_timeout() fix for core/seq/seq_instr.c
Date: Tue, 18 Sep 2007 16:27:36 +0200 [thread overview]
Message-ID: <46EFE058.2030300@gmail.com> (raw)
In-Reply-To: <46EFD955.1000601@gmail.com>
On 09/18/2007 03:57 PM, Rene Herman wrote:
Subject was supposed to be as above.
> Well, if you insist, but thought I'd submit is seperately once again.
> The schedule_timeout() calls in there are so-so, will simply not
> schedule, but that
>
> while (instr->use)
> schedule_timeout(1);
>
> loop is dangerous. There's nothing that I can see that's stopping the
> compiler from turning this into an infinite loop:
>
> if (instr->use)
> while (1)
> schedule_timeout(1);
>
> I'll admit I have no idea where this code ends up, but if it's _ever_
> used this seems to not be good.
>
> Ofcourse, feel free to drop on the floor if you really do insist.
>
> Signed-off-by: Rene Herman <rene.herman@gmail.com>
Rene.
next prev parent reply other threads:[~2007-09-18 14:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 18:29 [PATCH] ad1838/cs4231 -- fix MCE timeout upon initial load Rene Herman
2007-09-10 21:40 ` Krzysztof Helt
2007-09-10 21:37 ` Takashi Iwai
2007-09-10 21:43 ` Rene Herman
2007-09-10 21:45 ` Rene Herman
2007-09-11 8:56 ` Krzysztof Helt
2007-09-11 20:42 ` Rene Herman
2007-09-17 21:04 ` Trent Piepho
2007-09-17 21:47 ` Krzysztof Helt
2007-09-18 1:18 ` Trent Piepho
2007-09-18 7:20 ` Krzysztof Helt
2007-09-19 1:27 ` Trent Piepho
2007-09-19 2:48 ` Rene Herman
2007-09-18 0:17 ` Rene Herman
2007-09-18 1:57 ` Rene Herman
2007-09-18 4:24 ` Rene Herman
2007-09-18 11:03 ` Rene Herman
2007-09-18 11:54 ` Takashi Iwai
2007-09-18 13:38 ` [ PATCH 1/4] alsa-kernel: schedule_timeout() fixes Rene Herman
2007-09-18 16:39 ` Takashi Iwai
2007-09-18 13:49 ` [PATCH 2/4] alsa-kernel: schedule_timeout() fix for kernel/drivers/input/touchscreen/ucb1400_ts.c Rene Herman
2007-09-18 13:58 ` Takashi Iwai
2007-09-18 13:58 ` Rene Herman
2007-09-18 13:57 ` [PATCH] ad1838/cs4231 -- fix MCE timeout upon initial load Rene Herman
2007-09-18 14:27 ` Rene Herman [this message]
2007-09-18 16:38 ` Takashi Iwai
2007-09-18 14:34 ` [PATCH 4/4] alsa-driver: schedule_timeout() fixes Rene Herman
2007-09-18 16:44 ` Takashi Iwai
2007-09-18 17:05 ` Rene Herman
2007-09-18 17:09 ` Rene Herman
2007-09-18 17:22 ` Takashi Iwai
2007-09-18 2:32 ` [PATCH] ad1838/cs4231 -- fix MCE timeout upon initial load Trent Piepho
2007-09-18 6:50 ` Rene Herman
2007-09-18 7:33 ` Krzysztof Helt
2007-09-18 8:02 ` Krzysztof Helt
2007-09-18 8:17 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EFE058.2030300@gmail.com \
--to=rene.herman@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=krzysztof.h1@gmail.com \
--cc=tiwai@suse.de \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox