From: "Krzysztof Helt" <krzysztof.h1@wp.pl>
To: Takashi Iwai <tiwai@suse.de>
Cc: Alsa-devel <alsa-devel@alsa-project.org>,
Rene Herman <rene.herman@gmail.com>
Subject: Re: [PATCH] sgalaxy: checkpatch fixes
Date: Wed, 05 Sep 2007 15:34:03 +0200 [thread overview]
Message-ID: <46deb04bbc13d@wp.pl> (raw)
In-Reply-To: LINKIFYcaGIaDIAHefbFCIBBIACJFGGceJBDAIbCFHGJBDCLINKIFYDeABAdHAEIGDaHDDfDHIaIEDBDJHaabJbACbcBHI <s5h1wdd8d07.wl%tiwai@suse.de>
Dnia 5-09-2007 o godz. 15:20 Takashi Iwai napisał(a):
> At Wed, 05 Sep 2007 00:24:33 +0200,
> Rene Herman wrote:
> > > -#if 0
> > > - snd_printdd("WSS signature = 0x%x\n", tmp);
> > > -#endif
> >
> > Please don't just kill debug code. It's very useful for the
next person
> > stepping in -- it's "functional commentary".
>
> Then let's get rid of "#if 0". snd_printdd() won't get compiled
> unless CONFIG_SND_DEBUG_DETECT is set, so there is no reason to
kill
> twice.
>
I have thought the same this morning.
Ok. Now I am confused. Should I fix the patch and post it or
should I do nothing with the sgalaxy.c as it will be (hopefully)
soon replaced by a new driver (Rene's)?
Regards,
Krzysztof
----------------------------------------------------
Walka jakiej nie widziałeś! KSW eliminacje,
nie wszyscy przejdą cało!
Zobacz na żywo we Wrocławiu już 15 września.
Więcej -> http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fksweliminacje.html&sid=12
next prev parent reply other threads:[~2007-09-05 13:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 21:49 [PATCH] sgalaxy: checkpatch fixes Krzysztof Helt
2007-09-04 22:24 ` Rene Herman
2007-09-05 4:47 ` Krzysztof Helt
2007-09-05 12:23 ` Rene Herman
2007-09-05 13:20 ` Takashi Iwai
2007-09-05 13:34 ` Krzysztof Helt [this message]
2007-09-05 13:32 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46deb04bbc13d@wp.pl \
--to=krzysztof.h1@wp.pl \
--cc=alsa-devel@alsa-project.org \
--cc=rene.herman@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox