From: "Reddy, V sujith kumar" <vsujithkumar.reddy@amd.com>
To: Randy Dunlap <rdunlap@infradead.org>,
broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Sunil-kumar.Dommati@amd.com,
"open list" <linux-kernel@vger.kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Ajit Kumar Pandey" <AjitKumar.Pandey@amd.com>,
venkataprasad.potturu@amd.com,
"Meng Tang" <tangmeng@uniontech.com>,
Basavaraj.Hiregoudar@amd.com, "Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Yang Yingliang" <yangyingliang@huawei.com>,
"Jia-Ju Bai" <baijiaju1990@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Akihiko Odaki" <akihiko.odaki@gmail.com>,
Vijendar.Mukunda@amd.com,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Syed Saba kareem" <ssabakar@amd.com>
Subject: Re: [PATCH 3/3] ASoC: amd: acp: Add legacy audio driver support for Rembrandt platform
Date: Thu, 7 Jul 2022 21:35:52 +0530 [thread overview]
Message-ID: <472517b9-523e-36a2-9f00-e718ba0708f3@amd.com> (raw)
In-Reply-To: <6a210c39-2a04-2d39-9d5f-51b4e777b81d@infradead.org>
On 6/25/2022 4:34 AM, Randy Dunlap wrote:
> [CAUTION: External Email]
>
> Hi--
>
> On 6/24/22 12:48, V sujith kumar Reddy wrote:
>> diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
>> index 7e56d2644105..abc089f38b6c 100644
>> --- a/sound/soc/amd/acp/Kconfig
>> +++ b/sound/soc/amd/acp/Kconfig
>> @@ -40,6 +40,17 @@ config SND_AMD_ASOC_RENOIR
>> help
>> This option enables Renoir I2S support on AMD platform.
>>
>> +config SND_AMD_ASOC_REMBRANDT
>> + tristate "AMD ACP ASOC Rembrandt Support"
>> + select SND_SOC_AMD_ACP_PCM
>> + select SND_SOC_AMD_ACP_I2S
>> + select SND_SOC_AMD_ACP_PDM
>> + depends on X86 && PCI
>> + help
>> + This option enables Rembrandt I2S support on AMD platform.
>> + Say Y if you want to enable AUDIO on Rembrandt
>> + If unsure select "N".
>
Done
> Documentation/process/coding-style.rst says:
>
> 10) Kconfig configuration files
> -------------------------------
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different. Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
>
>
> so please indent as expected, and consistently.
>
> --
> ~Randy
next prev parent reply other threads:[~2022-07-07 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 19:48 [PATCH 0/3] ADD legacy audio driver support for rembrandt V sujith kumar Reddy
2022-06-24 19:48 ` [PATCH 1/3] ASoC: amd: acp: Remove rt1019_1 codec conf from machine driver V sujith kumar Reddy
2022-06-24 19:48 ` [PATCH 2/3] ASoC: amd: acp: ACP code generic to support newer platforms V sujith kumar Reddy
2022-06-24 19:48 ` [PATCH 3/3] ASoC: amd: acp: Add legacy audio driver support for Rembrandt platform V sujith kumar Reddy
2022-06-24 23:04 ` Randy Dunlap
2022-07-07 16:05 ` Reddy, V sujith kumar [this message]
[not found] ` <202206250650.DKkqPR4A-lkp@intel.com>
2022-07-07 16:05 ` Reddy, V sujith kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472517b9-523e-36a2-9f00-e718ba0708f3@amd.com \
--to=vsujithkumar.reddy@amd.com \
--cc=AjitKumar.Pandey@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=baijiaju1990@gmail.com \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=geert+renesas@glider.be \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=ssabakar@amd.com \
--cc=tangmeng@uniontech.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=venkataprasad.potturu@amd.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox