Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@keyaccess.nl>
To: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@suse.cz>
Cc: Alsa-devel <alsa-devel@alsa-project.org>,
	Krzysztof Helt <krzysztof.h1@poczta.fm>
Subject: Re: conversion of opti93x driver to use cs4231-lib
Date: Tue, 08 Jan 2008 15:16:57 +0100	[thread overview]
Message-ID: <478385D9.1000402@keyaccess.nl> (raw)
In-Reply-To: <s5hlk707dj7.wl%tiwai@suse.de>

On 08-01-08 12:38, Takashi Iwai wrote:

Jaroslav -- do you know/remember why opti93x didn't use cs4231-lib?

> At Mon, 7 Jan 2008 20:08:01 +0100,
> Krzysztof Helt wrote:
>> Hi,
>>
>> I posted some time ago two patches which converts opti93x driver to use cs4231-lib library. 
>>
>> The opti93x chips are almost compatible with the cs4231 differing mostly by mixer.
>>
>> This change greatly reduces the source of the opti drivers.
>>
>> Here are patches:
>> [addition of opti93x details to the cs4231-lib]
>> http://mailman.alsa-project.org/pipermail/alsa-devel/2007-September/003395.html
>>
>> and 
>> [conversion of opti93x driver to use cs4231-lib]
>> http://mailman.alsa-project.org/pipermail/alsa-devel/2007-September/003396.html
>>
>> I will rediff the second patch as there were some changes to opti93x driver after sending the patch.
>>
>> If it is not a good idea to do such conversion, please reply and drop patches.
> 
> The only concern is whether this breaks the workign opti9xx stuff.
> If someone can confirm it's OK, then I'm 100% for these patches.
> 
> Added Rene to Cc to hear his opinion.

Missed this one originally. I'll look into this in some detail but will need 
a few days. Obviously, if it works, it's desirable. Maybe Jaroslav knows why 
it's not that way now?

Rene.

  reply	other threads:[~2008-01-08 14:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 19:08 conversion of opti93x driver to use cs4231-lib Krzysztof Helt
2008-01-08 11:38 ` Takashi Iwai
2008-01-08 14:16   ` Rene Herman [this message]
2008-01-08 14:36     ` Rene Herman
2008-01-20 16:13       ` Rene Herman
2008-01-08 15:15     ` Jaroslav Kysela
2008-01-08 16:32     ` Krzysztof Helt
  -- strict thread matches above, loose matches on Subject: below --
2008-01-22  9:56 krzysztof.h1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478385D9.1000402@keyaccess.nl \
    --to=rene.herman@keyaccess.nl \
    --cc=alsa-devel@alsa-project.org \
    --cc=krzysztof.h1@poczta.fm \
    --cc=perex@suse.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox