From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Banajit Goswami <bgoswami@codeaurora.org>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Patrick Lai <plai@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: codecs: msm8916-wcd-digital: add support to set_sysclk
Date: Mon, 17 Jul 2017 15:52:40 +0100 [thread overview]
Message-ID: <47b03a33-a981-a27a-562e-af4d665cd219@linaro.org> (raw)
In-Reply-To: <20170717144450.lk7xfnwtkvt26qvw@sirena.org.uk>
On 17/07/17 15:44, Mark Brown wrote:
> On Mon, Jul 17, 2017 at 03:54:08PM +0200, srinivas.kandagatla@linaro.org wrote:
>
>> +static int msm8916_set_dai_sysclk(struct snd_soc_dai *dai,
>> + int clk_id, unsigned int freq, int dir)
>> +{
>> + struct msm8916_wcd_digital_priv *p = dev_get_drvdata(dai->codec->dev);
>> +
>> + clk_set_rate(p->mclk, freq);
>
> This is ignoring the return value.
>
Thanks, I will take care of it in next version.
--srini
next prev parent reply other threads:[~2017-07-17 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 13:54 [PATCH 0/3] ASoC: codecs: msm8916-wcd-digital: Fix dmic support srinivas.kandagatla
2017-07-17 13:54 ` [PATCH 1/3] ASoC: codecs: msm8916-wcd-digital: add support to set_sysclk srinivas.kandagatla
2017-07-17 14:44 ` Mark Brown
2017-07-17 14:52 ` Srinivas Kandagatla [this message]
2017-07-17 13:54 ` [PATCH 2/3] ASoC: qcom: apq8016-sbc: set default mclk rate srinivas.kandagatla
2017-07-17 13:54 ` [PATCH 3/3] ASoC: codecs: msm8916-wcd-digital: fix dmic support srinivas.kandagatla
2017-07-17 14:45 ` Mark Brown
2017-07-17 14:52 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47b03a33-a981-a27a-562e-af4d665cd219@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).