From: Marek Vasut <marex@denx.de>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Xiubo Li <Xiubo.Lee@gmail.com>,
Timur Tabi <timur@tabi.org>, Liam Girdwood <lgirdwood@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH 4/5] ASoC: fsl_ssi: use flat regmap cache
Date: Wed, 28 Sep 2016 01:29:04 +0200 [thread overview]
Message-ID: <47f75359-c8cc-2eb4-5683-88c6070bd7b5@denx.de> (raw)
In-Reply-To: <57EAFF75.60903@maciej.szmigiero.name>
On 09/28/2016 01:23 AM, Maciej S. Szmigiero wrote:
> On 26.09.2016 21:25, Marek Vasut wrote:
>> On 09/26/2016 09:13 PM, Mark Brown wrote:
> (..)
>>> So, can we get a clear decision on this after testing? The discussion
>>> here and the discussion on IRC are a bit disjointed and I'd like to make
>>> sure we end up with something that definitely works.
>>>
>> I think 1,2,3,4 are certainly harmless. I think even 5 is harmless (at
>> least according to my testing on MX6Q and MX6SX, which is not the
>> greatest sample), but can be safely reverted if there are concerns.
>
> I've tested current sound/for-next on UDOO board and was able to reproduce
> a lockup on reloading fsl sound modules.
> The exact test was playing 30 second sound file and reloading modules in
> a loop.
> The lockup would happen sometimes almost immediately and sometimes after
> ~30 minutes of such testing.
>
> When I reverted commit 7de2763d9b325ee5e7e24ac513c93394406cfefa
> (that is, number 5) it seems that it no longer locks up.
Do you have an explanation how would #5 cause this problem if it was
supposed to fix it ? ;-) Can you share the backtrace ?
>> I also believe the following two patches should be backported for stable
>> 4.7 (they were part of tag 'regmap-fix-v4.8-rc5' of
>> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap):
>>
>> commit b2c7f5d9c939a37c1ce7f86a642de70e3033ee9e
>> Author: Maarten ter Huurne <maarten@treewalker.org>
>> Date: Fri Jul 29 23:42:12 2016 +0200
>>
>> regmap: cache: Fix num_reg_defaults computation from reg_defaults_raw
>>
>> commit 1bc8da4e143c0fd8807e061a66d91d5972601ab1
>> Author: Lars-Peter Clausen <lars@metafoo.de>
>> Date: Thu Aug 4 17:22:16 2016 +0200
>>
>> regmap: rbtree: Avoid overlapping nodes
>>
>
> I can see that
> "regmap: cache: Fix num_reg_defaults computation from reg_defaults_raw" is
> present in the tree that I have tested.
And the rbtree patch is also present ?
> Maciej
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-09-27 23:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 19:30 [PATCH 1/5] ASoC: fsl_asrc: use flat regmap cache Marek Vasut
2016-09-19 19:30 ` [PATCH 2/5] ASoC: fsl_esai: " Marek Vasut
2016-09-21 12:56 ` Applied "ASoC: fsl_esai: use flat regmap cache" to the asoc tree Mark Brown
2016-09-19 19:30 ` [PATCH 3/5] ASoC: fsl_spdif: use flat regmap cache Marek Vasut
2016-09-21 12:56 ` Applied "ASoC: fsl_spdif: use flat regmap cache" to the asoc tree Mark Brown
2016-09-19 19:30 ` [PATCH 4/5] ASoC: fsl_ssi: use flat regmap cache Marek Vasut
2016-09-21 12:55 ` Applied "ASoC: fsl_ssi: use flat regmap cache" to the asoc tree Mark Brown
2016-09-21 16:28 ` [PATCH 4/5] ASoC: fsl_ssi: use flat regmap cache Maciej S. Szmigiero
2016-09-21 19:32 ` Marek Vasut
2016-09-21 22:18 ` Maciej S. Szmigiero
2016-09-21 22:45 ` Marek Vasut
2016-09-21 23:33 ` Maciej S. Szmigiero
2016-09-22 10:45 ` Mark Brown
2016-09-22 14:37 ` Maciej S. Szmigiero
2016-09-22 15:27 ` Marek Vasut
2016-09-22 23:38 ` Maciej S. Szmigiero
2016-09-26 19:13 ` Mark Brown
2016-09-26 19:25 ` Marek Vasut
2016-09-26 21:03 ` Mark Brown
2016-09-27 23:23 ` Maciej S. Szmigiero
2016-09-27 23:29 ` Marek Vasut [this message]
2016-09-28 0:04 ` Maciej S. Szmigiero
2016-09-28 19:09 ` Marek Vasut
2016-09-22 15:23 ` Marek Vasut
2016-09-19 19:30 ` [PATCH 5/5] ASoC: fsl_ssi: Remove .num_reg_defaults_raw from regmap_config Marek Vasut
2016-09-20 17:56 ` Mark Brown
2016-09-20 18:23 ` Marek Vasut
2016-09-21 12:55 ` Applied "ASoC: fsl_ssi: Remove .num_reg_defaults_raw from regmap_config" to the asoc tree Mark Brown
2016-09-20 6:50 ` [PATCH 1/5] ASoC: fsl_asrc: use flat regmap cache Nicolin Chen
2016-09-20 18:07 ` Fabio Estevam
2016-09-21 12:56 ` Applied "ASoC: fsl_asrc: use flat regmap cache" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f75359-c8cc-2eb4-5683-88c6070bd7b5@denx.de \
--to=marex@denx.de \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=mail@maciej.szmigiero.name \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).