Re: [PATCH 1/2] wss_lib: move cs4231_lib into wss_lib

[Rene Herman <rene.herman@keyaccess.nl>]

On 19-06-08 23:07, Krzysztof Helt wrote:

> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> Move the file sound/isa/cs423x/cs4231_lib.c 
> into sound/isa/cs423x/wss_lib.c
> This is the first step toward merging all libraries
> for Windows Sound System compatible chips
> into a single library.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>

Acked-by: Rene Herman <rene.herman@gmail.com>

Only small request:

> diff -urNp linux-alsa/sound/isa/wss/Makefile linux-mm/sound/isa/wss/Makefile
> --- linux-alsa/sound/isa/wss/Makefile	1970-01-01 01:00:00.000000000 +0100
> +++ linux-mm/sound/isa/wss/Makefile	2008-06-15 22:38:44.705642447 +0200
> @@ -0,0 +1,10 @@
> +#
> +# Makefile for ALSA
> +# Copyright (c) 2008 by Krzysztof Helt <krzysztof.h1@wp.pl>
> +#
> +
> +snd-wss-lib-objs := wss_lib.o
> +
> +# Toplevel Module Dependency
> +obj-$(CONFIG_SND_WSS_LIB) += snd-wss-lib.o
> +

Could you maybe "donate" the copyright on this Makefile to Jaroslav Kysela?

Basically, this single file is too trivial (and uncreative due to being 
rather fully dictated by the build-system as a whole) to be protectable 
under copyright in the first place but the ALSA build system as a whole 
IS copyrightable and Jaroslav holds the copyright on all others (except 
David Miller on the one sparc specific one).

It's likely not a practical issue really but I feel it's probably good 
to keep this concentrated.

Rene.