Re: [PATCH 2/2] Update Poodle to current ASoC API

[Eric Miao <eric.y.miao@gmail.com>]

Mark Brown wrote:
> On Thu, Jul 24, 2008 at 09:38:19PM +0800, Eric Miao wrote:
>> Mark Brown wrote:
> 
>>> I've queued this for Takashi, thanks (he's on holiday this week).  I
>>> had thought that at least the second hunk was already fixed but it seems
>>> not.
> 
>> This probably should go through the arm tree, along with other
>> poodle patches, otherwise it just creates headache for Russell
>> in the next merge.
> 
> Avoiding headaches for Russell was part of the goal here - ASoC is
> currently undergoing some fairly invasive renovations which increase the
> chances of conflicts being introduced with changes done to sound/soc
> outside that.
> 
> This patch is in sound/soc only so it can't directly conflict with the
> arch/arm changes that Russell is or will be carrying.
> 

Oh, I've mistaken it with the poodle.c in arch/arm/mach-pxa.

>> As if should go into 2.6.27, I don't know. Depending on if it
>> qualifies to be a fix or just a clean-up, from ALSA's point of
>> view.
> 
> Currently it fails to build, partially fixed by this patch, so it's
> not just coding style.

Right, and I was just wondering why those "snd_*_t" still exists.