Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sedji Gaouaou <sedji.gaouaou@atmel.com>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: alsa-devel@alsa-project.org,
	Dmitry Baryshkov <dbaryshkov@gmail.com>,
	Eric Miao <eric.miao@marvell.com>,
	Jean Delvare <khali@linux-fr.org>,
	Richard Purdie <rpurdie@rpsys.net>,
	Andrew Victor <linux@maxim.org.za>,
	Liam Girdwood <lrg@kernel.org>
Subject: Re: [PATCH] ASoC: Convert wm8731 to a new-style	i2c driver (testers wanted)
Date: Mon, 01 Sep 2008 15:54:53 +0200	[thread overview]
Message-ID: <48BBF42D.5010901@atmel.com> (raw)
In-Reply-To: <20080828184251.GA21868@roarinelk.homelinux.net>

Hi Manuel,
>  
> diff --git a/sound/soc/pxa/corgi.c b/sound/soc/pxa/corgi.c
> index 72b7a51..4837bdb 100644
> --- a/sound/soc/pxa/corgi.c
> +++ b/sound/soc/pxa/corgi.c
> @@ -328,18 +328,11 @@ static struct snd_soc_machine snd_soc_machine_corgi = {
>  	.num_links = 1,
>  };
>  
> -/* corgi audio private data */
> -static struct wm8731_setup_data corgi_wm8731_setup = {
> -	.i2c_bus = 0,
> -	.i2c_address = 0x1b,
> -};
> -
>  /* corgi audio subsystem */
>  static struct snd_soc_device corgi_snd_devdata = {
>  	.machine = &snd_soc_machine_corgi,
>  	.platform = &pxa2xx_soc_platform,
>  	.codec_dev = &soc_codec_dev_wm8731,
> -	.codec_data = &corgi_wm8731_setup,
>  };
>  
>  static struct platform_device *corgi_snd_device;
> diff --git a/sound/soc/pxa/poodle.c b/sound/soc/pxa/poodle.c
> index f84f7d8..a6adb46 100644
> --- a/sound/soc/pxa/poodle.c
> +++ b/sound/soc/pxa/poodle.c
> @@ -282,18 +282,11 @@ static struct snd_soc_machine snd_soc_machine_poodle = {
>  	.num_links = 1,
>  };
>  
> -/* poodle audio private data */
> -static struct wm8731_setup_data poodle_wm8731_setup = {
> -	.i2c_bus = 0,
> -	.i2c_address = 0x1b,
> -};
> -
>  /* poodle audio subsystem */
>  static struct snd_soc_device poodle_snd_devdata = {
>  	.machine = &snd_soc_machine_poodle,
>  	.platform = &pxa2xx_soc_platform,
>  	.codec_dev = &soc_codec_dev_wm8731,
> -	.codec_data = &poodle_wm8731_setup,
>  };
>  
>  static struct platform_device *poodle_snd_device;

Shouldn't it be the same for the file sound/soc/at91/eti_b1_wm8731.c ??

Regards,
Sedji

      parent reply	other threads:[~2008-09-01 13:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 16:24 [PATCH] ASoC: Convert wm8731 to a new-style i2c driver (testers wanted) Jean Delvare
2008-08-26 19:08 ` Mark Brown
2008-08-26 19:20 ` Manuel Lauss
2008-08-26 19:26   ` Jean Delvare
2008-08-26 19:37   ` Mark Brown
2008-08-28 17:25     ` Manuel Lauss
2008-08-28 17:37       ` Jean Delvare
2008-08-28 18:42         ` Manuel Lauss
2008-08-28 19:33           ` Mark Brown
2008-09-01 13:54           ` Sedji Gaouaou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BBF42D.5010901@atmel.com \
    --to=sedji.gaouaou@atmel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dbaryshkov@gmail.com \
    --cc=eric.miao@marvell.com \
    --cc=khali@linux-fr.org \
    --cc=linux@maxim.org.za \
    --cc=lrg@kernel.org \
    --cc=mano@roarinelk.homelinux.net \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox