From: Sedji Gaouaou <sedji.gaouaou@atmel.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, Geoffrey Wossum <geoffrey@pager.net>,
Frank Mandarino <fmandarino@endrelia.com>
Subject: Re: [PATCH]ASoC: Create a common directory for AVR32 and ARM9 atmel boards.
Date: Thu, 02 Oct 2008 18:00:37 +0200 [thread overview]
Message-ID: <48E4F025.80907@atmel.com> (raw)
In-Reply-To: <20081002150731.GH2848@sirena.org.uk>
Mark Brown a écrit :
> On Thu, Oct 02, 2008 at 09:50:26AM +0200, Sedji Gaouaou wrote:
>
>> Create a common directory for AVR32 and ARM9 atmel boards to unify atmel
>> audio DAI.
>
>> Signed-off-by: Sedji Gaouaou <sedji.gaouaou@atmel.com>
>
> Hrm. It doesn't look like playpaq_wm8510.c will build after this change
> - for one thing, at32-pcm.h and at32-ssc.h don't exist any more in the
> new atmel directory but there's no change to the file to reflect that.
> If you're unable to test AVR32 yourself then perhaps Geoffrey (CCed)
> will be able to help out here?
>
Yes my mistake!! I will change change right now. Nevertheless I don't
even have a AVR compiler so I can't really test the AVR code....
> Also, please note the changes to the playpaq driver which were made in
> commit c2d8a0f79a63e3d3ead52fba3a6300f86514758b which was merged into
> Takashi's tree the other day.
>
Again my mistake :)
> Can I also suggest splitting this up so that you do the merge of the
> existing code in one patch then add your new board drivers in another?
> If nothing else it'd bring down the size of the main diff. :)
>
Ok, no worries. I will create:
a patch that contains the atmel_ssc_dai.c and .h file,
a patch for the atmel-pcm.c/.h files
a patch playback_wm8510.c and sam9g20_wm8731.c files.
a patch for the Makefile and the Kconfig.
Is that ok?
next prev parent reply other threads:[~2008-10-02 16:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 7:50 [PATCH]ASoC: Create a common directory for AVR32 and ARM9 atmel boards Sedji Gaouaou
2008-10-02 15:07 ` Mark Brown
2008-10-02 16:00 ` Sedji Gaouaou [this message]
2008-10-02 18:12 ` Mark Brown
2008-10-03 12:44 ` Sedji Gaouaou
2008-10-03 13:14 ` Mark Brown
2008-10-03 14:22 ` Sedji Gaouaou
2008-10-03 14:35 ` Mark Brown
2008-10-03 14:39 ` Sedji Gaouaou
2008-10-03 14:41 ` Geoffrey Wossum
2008-10-03 14:49 ` Haavard Skinnemoen
2008-10-03 14:51 ` Sedji Gaouaou
2008-10-03 15:06 ` Haavard Skinnemoen
2008-10-03 15:12 ` Sedji Gaouaou
2008-10-06 14:17 ` Haavard Skinnemoen
2008-10-06 14:27 ` Mark Brown
2008-10-06 14:04 ` Geoffrey Wossum
-- strict thread matches above, loose matches on Subject: below --
2008-10-01 16:21 [PATCH] ASoC: " Sedji Gaouaou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E4F025.80907@atmel.com \
--to=sedji.gaouaou@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=fmandarino@endrelia.com \
--cc=geoffrey@pager.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox