Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2.6.27?] ASoC: Correct inverted Mic PGA Switch control in wm8510 driver
Date: Fri, 03 Oct 2008 10:20:53 -0700	[thread overview]
Message-ID: <48E65475.3040203@boundarydevices.com> (raw)
In-Reply-To: <1223041684-4449-1-git-send-email-broonie@opensource.wolfsonmicro.com>

Mark Brown wrote:
> Mic PGA Switch should be inverted in the WM8510 driver but isn't.
> 
> Reported-by: ext-jukka.hynninen@vaisala.com
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> 
> This bugfix applies to 2.6.27 but the issue is not very severe - it'd be
> good to get it in but it's not critical.
> 
>  sound/soc/codecs/wm8510.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/codecs/wm8510.c
> index 75ed041..f644da6 100644
> --- a/sound/soc/codecs/wm8510.c
> +++ b/sound/soc/codecs/wm8510.c
> @@ -199,7 +199,7 @@ SOC_DAPM_SINGLE("PCM Playback Switch", WM8510_MONOMIX, 0, 1, 0),
>  };
>  
>  static const struct snd_kcontrol_new wm8510_boost_controls[] = {
> -SOC_DAPM_SINGLE("Mic PGA Switch", WM8510_INPPGA,  6, 1, 0),
> +SOC_DAPM_SINGLE("Mic PGA Switch", WM8509_INPPGA,  6, 1, 1),
>  SOC_DAPM_SINGLE("Aux Volume", WM8510_ADCBOOST, 0, 7, 0),
>  SOC_DAPM_SINGLE("Mic Volume", WM8510_ADCBOOST, 4, 7, 0),
>  };

Why the WM509 prefix instead of WM8510?

  reply	other threads:[~2008-10-03 17:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 13:48 [PATCH 2.6.27?] ASoC: Correct inverted Mic PGA Switch control in wm8510 driver Mark Brown
2008-10-03 17:20 ` Troy Kisky [this message]
2008-10-03 17:47   ` Mark Brown
2008-10-04 16:35     ` Takashi Iwai
2008-10-04 18:16       ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2008-10-06 10:33 Mark Brown
2008-10-07  8:04 ` Takashi Iwai
2008-10-07 10:22   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E65475.3040203@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox