From: Matthew Ranostay <mranostay@embeddedalley.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH2/2] hda: Add support for IDT codecs to report jack presence
Date: Tue, 21 Oct 2008 11:20:35 -0400 [thread overview]
Message-ID: <48FDF343.6080907@embeddedalley.com> (raw)
In-Reply-To: <20081021085543.GD10841@sirena.org.uk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Mark Brown wrote:
> On Mon, Oct 20, 2008 at 05:40:22PM -0400, Matthew Ranostay wrote:
>> Add support for reporting line out, headphone, and microphone jack insertions
>> via the jack abstraction layer for the Sigmatel/IDT codec family.
>
> The jack detection side of this looks good - I've not really reviewed
> the HDA side of things. One comment:
>
>> + if (type == SND_JACK_SWITCH)
>> + type = (pin_ctl & AC_PINCTL_HP_EN)
>> + ? SND_JACK_HEADPHONE : SND_JACK_LINEOUT;
>
> So SND_JACK_SWITCH is just a jack that can be either headphone or
> lineout - like I said previously, you should not define a new jack type
> for this but just set both jack types when registering the jack.
>
Ok point taken :).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkj980MACgkQ7s2wy7nhBHWK0QCfThegngknAyJTiaFFFFC44ID/
qiIAn1cy4PrHYl0VAhBkyjPpQ7i710lr
=F4Hs
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2008-10-21 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 21:40 [PATCH2/2] hda: Add support for IDT codecs to report jack presence Matthew Ranostay
2008-10-21 8:55 ` Mark Brown
2008-10-21 15:20 ` Matthew Ranostay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FDF343.6080907@embeddedalley.com \
--to=mranostay@embeddedalley.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox