Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Angus Ainslie <angus@akkea.ca>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	kernel@puri.sm, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [alsa-devel] [PATCH v3 1/2] ASoC: gtm601: add Broadmobi bm818 sound profile
Date: Sun, 22 Dec 2019 08:26:51 -0800	[thread overview]
Message-ID: <499dffad51cb7819bd118ad15048816c@akkea.ca> (raw)
In-Reply-To: <20191220130143.GF4790@sirena.org.uk>

On 2019-12-20 05:01, Mark Brown wrote:
> On Thu, Dec 19, 2019 at 01:09:43PM -0800, Angus Ainslie (Purism) wrote:
> 
>>  static int gtm601_platform_probe(struct platform_device *pdev)
>>  {
>> +	struct snd_soc_dai_driver *dai_driver;
>> +
>> +	dai_driver = of_device_get_match_data(&pdev->dev);
>> +
> 
> I was going to apply this but it causes build warnings:
> 
> sound/soc/codecs/gtm601.c: In function ‘gtm601_platform_probe’:
> sound/soc/codecs/gtm601.c:83:13: warning: assignment discards ‘const’
> qualifier from pointer target type [-Wdiscarded-qualifiers]
>   dai_driver = of_device_get_match_data(&pdev->dev);
>              ^

Sorry, missed that.

New version inbound.

Angus
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-12-22 16:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 21:09 [alsa-devel] [PATCH v3 0/2] Add the broadmobi BM818 Angus Ainslie (Purism)
2019-12-19 21:09 ` [alsa-devel] [PATCH v3 1/2] ASoC: gtm601: add Broadmobi bm818 sound profile Angus Ainslie (Purism)
2019-12-20 12:59   ` Mark Brown
2019-12-20 13:01   ` Mark Brown
2019-12-22 16:26     ` Angus Ainslie [this message]
2019-12-19 21:09 ` [alsa-devel] [PATCH v3 2/2] dt-bindings: sound: gtm601: add the broadmobi interface Angus Ainslie (Purism)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499dffad51cb7819bd118ad15048816c@akkea.ca \
    --to=angus@akkea.ca \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kernel@puri.sm \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox