From: Timur Tabi <timur@freescale.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@sirena.org.uk>,
Liam Girdwood <lrg@kernel.org>
Subject: Re: [PATCH] ASoC: make ops a pointer in 'struct snd_soc_dai'
Date: Wed, 04 Mar 2009 15:32:58 -0600 [thread overview]
Message-ID: <49AEF38A.6050802@freescale.com> (raw)
In-Reply-To: <f17812d70903021740w5c0c5dfck5a92869650bf5bd7@mail.gmail.com>
Eric Miao wrote:
> Updated as below, (gzip version attached due to mailing list
> mail size limitation).
>
> From 74a2b6dfff2948d9d04b33d0a02f645f8c12caf7 Mon Sep 17 00:00:00 2001
> From: Eric Miao <eric.miao@marvell.com>
> Date: Mon, 2 Mar 2009 22:38:31 +0800
> Subject: [PATCH] ASoC: make ops a pointer of 'struct snd_soc_dai'
>
> Considering the fact that most cpu_dai or codec_dai are using a same
> 'snd_soc_dai_ops' for several similar interfaces, 'ops' would be better
> made a pointer instead, to make sharing easier and code a bit cleaner.
>
> The patch below is rather preliminary since the asoc tree is being
> actively developed, and this touches almost every piece of code,
> (and possibly many others in development need to be changed as
> well). Building of all codecs are OK, yet to every SoC, I didn't test
> that.
>
> Signed-off-by: Eric Miao <eric.miao@marvell.com>
Tested on an MPC8610 HPCD, and it works. That's all I can vouch for,
though.
Acked-by: Timur Tabi <timur@freescale.com>
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-03-04 21:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 3:25 [PATCH] ASoC: make ops a pointer in 'struct snd_soc_dai' Eric Miao
2009-03-02 11:13 ` Liam Girdwood
2009-03-02 11:50 ` Mark Brown
2009-03-02 11:55 ` Takashi Iwai
2009-03-03 3:33 ` Eric Miao
2009-03-03 11:43 ` Mark Brown
2009-03-02 12:39 ` Timur Tabi
[not found] ` <f17812d70903020646q15d43dcch8ad90df2cb486499@mail.gmail.com>
2009-03-02 18:15 ` Timur Tabi
[not found] ` <f17812d70903021740w5c0c5dfck5a92869650bf5bd7@mail.gmail.com>
2009-03-04 15:00 ` Mark Brown
2009-03-04 21:32 ` Timur Tabi [this message]
2009-03-05 2:03 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AEF38A.6050802@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=eric.y.miao@gmail.com \
--cc=lrg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox