From: "Daniel Glöckner" <dg@emlix.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 1/2] alsa: ASoC driver for s6000 I2S interface
Date: Mon, 06 Apr 2009 11:48:49 +0200 [thread overview]
Message-ID: <49D9D001.7070901@emlix.com> (raw)
In-Reply-To: <20090404143741.GA6474@sirena.org.uk>
On 04/04/2009 04:37 PM, Mark Brown wrote:
> This all looks good - the only concern I have is the issue with the
> polarity of the clock signals I mentioned in reply to the machine
> driver. The code in the machine driver does make it look like the I2S
> driver is using the opposite polarity to that expected.
You are right, this is wrong.
Patch follows
Daniel
--
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax -11, Bahnhofsallee 1b, 37081 Göttingen, Germany
Geschäftsführung: Dr. Uwe Kracke, Dr. Cord Seele, Ust-IdNr.: DE 205 198 055
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
emlix - your embedded linux partner
next prev parent reply other threads:[~2009-04-06 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-28 18:47 [PATCH v2 1/2] alsa: ASoC driver for s6000 I2S interface Daniel Glöckner
2009-03-28 18:47 ` [PATCH v2 2/2] alsa: s6105 IP camera machine specific ASoC code Daniel Glöckner
2009-04-01 13:29 ` Mark Brown
2009-04-04 14:37 ` [PATCH v2 1/2] alsa: ASoC driver for s6000 I2S interface Mark Brown
2009-04-06 9:48 ` Daniel Glöckner [this message]
2009-04-06 9:50 ` [PATCH] ASoC: correct s6000 I2S clock polarity Daniel Glöckner
2009-04-06 10:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D9D001.7070901@emlix.com \
--to=dg@emlix.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox