From: Viral Mehta <viral.mehta@einfochips.com>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH][SOUND]volume control for CSWITCH and CROUTE
Date: Tue, 07 Apr 2009 10:10:59 +0530 [thread overview]
Message-ID: <49DAD95B.5090707@einfochips.com> (raw)
In-Reply-To: <s5htz51i3ik.wl%tiwai@suse.de>
Takashi Iwai wrote:
> At Sat, 04 Apr 2009 18:08:28 +0530,
> Viral Mehta wrote:
>
>> From: Deepika Makhija <deepika.makhija@einfochips.com>
>>
>> Added an else part to check
>> SNDRV_MIXER_OSS_PRESENT_CVOLUME for MIC (slot 7)
>> in commit 36c7b833e5d2501142a371e4e75281d3a29fbd6b
>>
>> Similarly, checks and volume control is required for
>> SNDRV_MIXER_OSS_PRESENT_CSWITCH and SNDRV_MIXER_OSS_PRESENT_CROUTE
>> as well.
>>
>> Signed-off-by: Deepika Makhija <deepika.makhija@einfochips.com>
>> Signed-off-by: Viral Mehta <viral.mehta@einfochips.com>
>>
>
> Thanks, applied now to sound git tree.
>
> The original patch wasn't applicable (the file name was wrong) so I
> had to apply the patch manually. It'd be helpful to test the patch
> before submission at the next time :)
>
>
> Takashi
>
Thanks for taking care. I am sorry about that mistake.
Yeah, lately I have learned using checkpatch.pl and things which are
helpful before patch submission.
Thanks again,
Viral
prev parent reply other threads:[~2009-04-07 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-04 12:38 [PATCH][SOUND]volume control for CSWITCH and CROUTE Viral Mehta
2009-04-07 2:47 ` Takashi Iwai
2009-04-07 4:40 ` Viral Mehta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DAD95B.5090707@einfochips.com \
--to=viral.mehta@einfochips.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox