From: Clemens Ladisch <clemens@ladisch.de>
To: Florian Faber <faber@faberman.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] hdspm: native float
Date: Thu, 16 Apr 2009 13:48:46 +0200 [thread overview]
Message-ID: <49E71B1E.8020306@ladisch.de> (raw)
In-Reply-To: <1239878648.10715.2.camel@x200.watzmann.local>
Florian Faber wrote:
> > > > /* Switch to native float format if requested */
> > > > ...
> > > > hdspm_write(hdspm, HDSPM_controlRegister, hdspm->control_register);
> >
> > This looks like a global change. What happens when playback and
> > recording want to use different formats?
>
> It is a global change. The only use case is for jack, and jack doesn't
> use different formats for input/output.
"Using aplay + arecord" is a second use case. :-)
Anyway, at least add a check that the formats are actually the same
(like the checks for sample rate and period size).
Best regards,
Clemens
next prev parent reply other threads:[~2009-04-16 11:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 17:11 [PATCH] hdspm: native float Florian Faber
2009-04-16 10:01 ` Clemens Ladisch
2009-04-16 10:44 ` Florian Faber
2009-04-16 11:48 ` Clemens Ladisch [this message]
2009-04-16 12:12 ` Florian Faber
2009-04-16 12:36 ` Takashi Iwai
2009-04-16 12:41 ` Mark Brown
2009-04-16 18:01 ` John Rigg
2009-04-16 18:32 ` John Rigg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E71B1E.8020306@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=faber@faberman.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox