From: Timur Tabi <timur@freescale.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@sirena.org.uk>
Subject: Re: [PATCH 2/2] ASoC: cs4270: add power management support
Date: Tue, 05 May 2009 10:30:48 -0500 [thread overview]
Message-ID: <4A005BA8.2070600@freescale.com> (raw)
In-Reply-To: <1241515501-6600-2-git-send-email-daniel@caiaq.de>
Daniel Mack wrote:
> +static int cs4270_i2c_suspend(struct i2c_client *client, pm_message_t mesg)
> +{
> + struct cs4270_private *cs4270 = i2c_get_clientdata(client);
> + struct snd_soc_codec *codec = &cs4270->codec;
> + int reg = snd_soc_read(codec, CS4270_PWRCTL);
> +
> + if (reg < 0)
> + return reg;
You check for an error code from snd_soc_read() here, but ...
> + /* ... then disable the power-down bits */
> + reg = snd_soc_read(codec, CS4270_PWRCTL);
you don't check for it here.
In cs4270_i2c_suspend(), snd_soc_read() can never return an error,
because you're passing a hard-coded register address.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-05-05 15:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 9:25 [PATCH 1/2] ASoC: cs4270: introduce CS4270_I2C_INCR Daniel Mack
2009-05-05 9:25 ` [PATCH 2/2] ASoC: cs4270: add power management support Daniel Mack
2009-05-05 15:30 ` Timur Tabi [this message]
2009-05-05 15:51 ` Daniel Mack
2009-05-05 17:55 ` Timur Tabi
2009-05-05 23:26 ` Daniel Mack
2009-05-06 15:27 ` Timur Tabi
2009-05-07 8:02 ` Mark Brown
2009-05-05 14:51 ` [PATCH 1/2] ASoC: cs4270: introduce CS4270_I2C_INCR Timur Tabi
2009-05-05 15:15 ` Daniel Mack
2009-05-05 18:09 ` Mark Brown
2009-05-05 23:19 ` Daniel Mack
2009-05-06 8:44 ` Mark Brown
2009-05-06 9:39 ` Daniel Mack
2009-05-06 15:28 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A005BA8.2070600@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=daniel@caiaq.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox