From: Karl Beldan <karl.beldan@gmail.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Eric Miao <eric.miao@marvell.com>,
alsa-devel@alsa-project.org,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
Matthieu Dumont <matthieu.dumont@mobile-devices.fr>
Subject: Re: [PATCH 2/4] pxa2xx-i2s: Handle SACR1_DRPL and SACR1_DREC separately
Date: Mon, 11 May 2009 21:43:11 +0200 [thread overview]
Message-ID: <4A087FCF.2080304@gmail.com> (raw)
In-Reply-To: <20090511190504.GF20283@sirena.org.uk>
Mark Brown wrote:
> On Fri, May 08, 2009 at 11:42:29AM +0100, Mark Brown wrote:
>
>> ...this really ought to be a separate patch. I'll wait until Monday
>> when I'm back in the office before applying so I can test.
>
> This patch is causing problems in my testing. With the patch the clocks
> are not stopped when closing the stream, causing the next playback to
> fail. However, the error handling from that causes the appropriate
> cleanup and allows playback to proceed.
>
To be sure:
With current tree you do not have this problem.
You applied 1/4 and 2/4 and you have this problem.
Right ?
> I've not had time to review properly what's going on here - I suspect
> that the splits in the patch series need to be looked at but for now
> I'll not apply this.
--
Karl
next prev parent reply other threads:[~2009-05-11 19:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 23:53 [PATCH 2/4] pxa2xx-i2s: Handle SACR1_DRPL and SACR1_DREC separately Karl Beldan
2009-05-08 10:42 ` Mark Brown
2009-05-08 19:24 ` Karl Beldan
2009-05-11 19:05 ` Mark Brown
2009-05-11 19:43 ` Karl Beldan [this message]
2009-05-11 21:07 ` Mark Brown
2009-05-11 22:00 ` Karl Beldan
2009-05-12 8:58 ` Mark Brown
2009-05-12 9:59 ` Karl Beldan
2009-05-12 10:32 ` Mark Brown
2009-05-12 12:38 ` Karl Beldan
2009-05-12 14:34 ` Mark Brown
2009-05-12 16:02 ` Mark Brown
2009-05-12 17:43 ` Karl Beldan
2009-05-12 21:50 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2009-05-13 20:04 Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A087FCF.2080304@gmail.com \
--to=karl.beldan@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=eric.miao@marvell.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux@arm.linux.org.uk \
--cc=matthieu.dumont@mobile-devices.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox