From: Karl Beldan <karl.beldan@gmail.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Russell King <linux@arm.linux.org.uk>,
alsa-devel@alsa-project.org, Eric Miao <eric.miao@marvell.com>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
Matthieu Dumont <matthieu.dumont@mobile-devices.fr>
Subject: Re: [PATCH 1/4 v3] pxa2xx-i2s: Proper hw initialization
Date: Thu, 14 May 2009 10:41:41 +0200 [thread overview]
Message-ID: <4A0BD945.8000208@gmail.com> (raw)
In-Reply-To: <4A0BD855.1060000@gmail.com>
Karl Beldan wrote:
> Karl Beldan wrote:
>> Make sure we are in a know good state at end of probe :
>> Reset FIFO logic and registers, and make sure REC and RPL functions
>> along with FIFO service are disabled (SACR0_RST enables REC and RPL).
>>
>> Resetting loses current settings so remove reset from stream startup.
>> Now reset occurs only at probe.
>>
>
> This differs from what you applied in that it includes 'removal of hw reset from
> pxa2xx_i2s_startup'.
> I understood including it in either one (1/4 or 2/4) is ok, since you had not
> pushed it yet. Otherwise I'll have to post a [PATCH 2/4 v3] including the reset,
> which would be identical to [PATCH 2/4] (initial version).
I meant 'which would be identical to [PATCH 2/4] (initial version) + reset'.
--
Karl
next prev parent reply other threads:[~2009-05-14 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 8:25 [PATCH 1/4 v3] pxa2xx-i2s: Proper hw initialization Karl Beldan
2009-05-14 8:37 ` Karl Beldan
2009-05-14 8:41 ` Karl Beldan [this message]
2009-05-14 19:49 ` Mark Brown
2009-05-14 20:19 ` Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0BD945.8000208@gmail.com \
--to=karl.beldan@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=eric.miao@marvell.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux@arm.linux.org.uk \
--cc=matthieu.dumont@mobile-devices.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox