Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nickolas Lloyd <ultrageek.lloyd@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Matthew Ranostay <mranostay@embeddedalley.com>
Subject: Re: [PATCH] snd-hda-intel: add controls to toggle DC bias on mic ports
Date: Fri, 15 May 2009 15:17:27 +0000	[thread overview]
Message-ID: <4A0D8787.9010104@gmail.com> (raw)
In-Reply-To: <s5hoctua2ne.wl%tiwai@suse.de>

Takashi Iwai wrote:
> At Wed, 13 May 2009 18:43:04 +0000,
> Nickolas Lloyd wrote:
>   
>> This patch adds a mixer control for the STAC92XX boards to control the
>> DC bias of mic ports, allowing recording from both powered and
>> non-powered sources.  It replaces the "Mic Output Switch" with "Mic Jack
>> Mode" to switch between Mic, Line In, and Line Out.
>>
>> Signed-off by: Nickolas Lloyd <ultrageek.lloyd@gmail.com>
>>
>> Note: diffed against alsa-driver-20090513
>>     
>
> Thanks, applied now.
>
> BTW, I think we should change also "Line as Output Switch" to "Line-In
> Jack Mode" or so to make the code consistent.  Care to create a patch?
>
>
> Takashi
>
>   
I'd be happy to.  Also, as it is now, the control will only be added if
autocfg.line_out_type is set to AUTO_PIN_LINE_OUT, so this control may
not be added for all mic ports.  I was thinking of making the enum show
only two entries, Line in and Mic in for these other mics.  Thoughts?

Thanks,
Nick

  reply	other threads:[~2009-05-15 22:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13 18:43 [PATCH] snd-hda-intel: add controls to toggle DC bias on mic ports Nickolas Lloyd
2009-05-13 19:12 ` Nickolas Lloyd
2009-05-15 13:58 ` Takashi Iwai
2009-05-15 15:17   ` Nickolas Lloyd [this message]
2009-05-19 13:13     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0D8787.9010104@gmail.com \
    --to=ultrageek.lloyd@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=mranostay@embeddedalley.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox