From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Fisher Subject: Re: [PATCH] Volume control quirk for QuickCam E 3500 Date: Wed, 22 Jul 2009 13:30:31 +0200 Message-ID: <4A66F857.9090309@fisher-privat.net> References: <1248259376-5204-1-git-send-email-bug-track@fisher-privat.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by alsa0.perex.cz (Postfix) with SMTP id 89BBC1038CB for ; Wed, 22 Jul 2009 13:30:33 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, clemens@ladisch.de List-Id: alsa-devel@alsa-project.org Takashi Iwai schrieb: > At Wed, 22 Jul 2009 12:42:56 +0200, > Alexey Fisher wrote: >> - E3500 report cval->max more than it actually can handel, so if you >> set 95% capture level it will be silently muted. >> - Betwen cval->min and cval-max(real) is 2940 control units, >> but real are only 7 with cval->res = 384. >> - Alsa can't handel less than 10 controls, so make it more >> and set cval->res = 192. >> >> Signed-off-by: Alexey Fisher > > They miss still break lines... > Could you fix it? Ok, i'll do every time checkpatch.pl. I promise :) thanky, Alexey > > thanks, > > Takashi > >> --- >> sound/usb/usbmixer.c | 23 ++++++++++++++++++----- >> 1 files changed, 18 insertions(+), 5 deletions(-) >> >> diff --git a/sound/usb/usbmixer.c b/sound/usb/usbmixer.c >> index 5c48199..c87bcd1 100644 >> --- a/sound/usb/usbmixer.c >> +++ b/sound/usb/usbmixer.c >> @@ -1000,20 +1000,33 @@ static void build_feature_ctl(struct mixer_build *state, unsigned char *desc, >> break; >> } >> >> - /* quirk for UDA1321/N101 */ >> - /* note that detection between firmware 2.1.1.7 (N101) and later 2.1.1.21 */ >> - /* is not very clear from datasheets */ >> - /* I hope that the min value is -15360 for newer firmware --jk */ >> + /* volume control quirks */ >> switch (state->chip->usb_id) { >> case USB_ID(0x0471, 0x0101): >> case USB_ID(0x0471, 0x0104): >> case USB_ID(0x0471, 0x0105): >> case USB_ID(0x0672, 0x1041): >> + /* quirk for UDA1321/N101. >> + * note that detection between firmware 2.1.1.7 (N101) >> + * and later 2.1.1.21 is not very clear from datasheets. >> + * I hope that the min value is -15360 for newer firmware --jk >> + */ >> if (!strcmp(kctl->id.name, "PCM Playback Volume") && >> cval->min == -15616) { >> - snd_printk(KERN_INFO "using volume control quirk for the UDA1321/N101 chip\n"); >> + snd_printk(KERN_INFO >> + "set volume quirk for UDA1321/N101 chip\n"); >> cval->max = -256; >> } >> + >> + case USB_ID(0x046d, 0x09a4): >> + if (!strcmp(kctl->id.name, "Mic Capture Volume")) { >> + snd_printk(KERN_INFO >> + "set volume quirk for QuickCam E3500\n"); >> + cval->min = 6080; >> + cval->max = 8768; >> + cval->res = 192; >> + } >> + >> } >> >> snd_printdd(KERN_INFO "[%d] FU [%s] ch = %d, val = %d/%d/%d\n", >> -- >> 1.6.3.3 >> > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel