From: Troy Kisky <troy.kisky@boundarydevices.com>
To: David Brownell <david-b@pacbell.net>,
Kevin Hilman <khilman@deeprootsystems.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
alsa-devel@alsa-project.org, broonie@sirena.org.uk
Subject: Re: [PATCH 2/3] ASoC: DaVinci: pcm, rename variables in prep for ping/pong
Date: Thu, 03 Sep 2009 15:38:47 -0700 [thread overview]
Message-ID: <4AA04577.2030803@boundarydevices.com> (raw)
In-Reply-To: <200909031436.01913.david-b@pacbell.net>
David Brownell wrote:
> On Thursday 03 September 2009, Troy Kisky wrote:
>> David Brownell wrote:
>>> On Monday 31 August 2009, Troy Kisky wrote:
>>>> - int master_lch; /* Master DMA channel */
>>>> - int slave_lch; /* linked parameter RAM reload slot */
>>>> + int asp_master_lch; /* Master DMA channel */
>>>> + int asp_link_lch[2]; /* asp parameter link channel, ping/pong */
>>> If you're going to rename things, may I suggest getting
>>> rid of "lch" ... use either "channel" or "link", since
>>> those are the two basic hardware roles in EDMA.
>> I agree, but can that be a separate patch...
>
> However you like; I'd just suggest that *one* rename-things
> patch is normally preferred. If this one's already in the
> merge queue that might be awkward.
>
Kevin,
Is the window too close, or is there time to change this?
Troy
next prev parent reply other threads:[~2009-09-03 22:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 23:31 [PATCH 1/3] ASoC: DaVinci: i2s, reduce underruns by combining into 1 element Troy Kisky
2009-08-31 23:31 ` [PATCH 2/3] ASoC: DaVinci: pcm, rename variables in prep for ping/pong Troy Kisky
2009-08-31 23:31 ` [PATCH 3/3] ASoC: DaVinci: pcm, fix underrun by using sram Troy Kisky
2009-09-02 22:01 ` [PATCH 2/3] ASoC: DaVinci: pcm, rename variables in prep for ping/pong Mark Brown
2009-09-03 0:15 ` Troy Kisky
2009-09-03 12:17 ` Mark Brown
[not found] ` <4A9F0A8C.1040509-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2009-09-03 16:43 ` [alsa-devel] " Nori, Sekhar
2009-09-03 18:55 ` Troy Kisky
[not found] ` <4AA0113D.9030605-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2009-09-09 12:08 ` [alsa-devel] " Nori, Sekhar
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB59301DD74F519-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-09-09 12:33 ` Caglar Akyuz
[not found] ` <200909091533.58702.caglarakyuz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-09-09 13:05 ` Nori, Sekhar
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB59301DD74F59E-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-09-09 13:22 ` Narnakaje, Snehaprabha
2009-09-09 13:28 ` Mark Brown
2009-09-29 10:46 ` [alsa-devel] " Nori, Sekhar
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB59301DDAB3EB5-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-09-29 15:21 ` Mani, Arun
[not found] ` <7A436F7769CA33409C6B44B358BFFF0C012A458365-EovWT4A8QTWIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-10-01 18:13 ` Nori, Sekhar
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB59301DDB71445-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-10-01 18:46 ` Steve Chen
2009-09-29 22:09 ` Troy Kisky
[not found] ` <4AC28588.9030802-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2009-09-29 22:25 ` [alsa-devel] " Steve Chen
2009-09-29 22:31 ` Troy Kisky
[not found] ` <4AC28AD0.7000600-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2009-09-29 23:24 ` [alsa-devel] " Steve Chen
2009-09-03 19:06 ` David Brownell
2009-09-03 19:24 ` Troy Kisky
2009-09-03 21:36 ` David Brownell
2009-09-03 22:38 ` Troy Kisky [this message]
2009-09-01 10:53 ` [PATCH 1/3] ASoC: DaVinci: i2s, reduce underruns by combining into 1 element Mark Brown
2009-09-01 18:23 ` Troy Kisky
2009-09-01 19:03 ` Mark Brown
2009-09-01 19:19 ` Troy Kisky
2009-09-01 20:28 ` Mark Brown
2009-09-01 20:42 ` Troy Kisky
2009-09-01 21:22 ` Mark Brown
2009-09-01 21:34 ` Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA04577.2030803@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=david-b@pacbell.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox