Re: [PATCH 1/2] ASoC: DaVinci: Fix divide by zero error during 1st execution

[Troy Kisky <troy.kisky@boundarydevices.com>]

Mark Brown wrote:
> On Fri, Sep 11, 2009 at 02:29:02PM -0700, Troy Kisky wrote:
>> When both playback and capture stream were open
>> davinci_i2s_hw_params was setting parameters for
>> the wrong stream. The fix for davinci_i2s_hw_params
>> is sufficient, but it looks like a race still happens
>> in davici_pcm_open. This patch also makes the race smaller
>> but the next patch provides a better fix.
> 
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> 
> Applied both, thanks.  Sorry about the delay in applying these - not
> sure what I was waiting for there.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

I think you were waiting for me to remove the need for the
comment:

+	/*
+	 * dma_params must be first because rtd->dai->cpu_dai->private_data
+	 * is cast to a pointer of an array of struct davinci_pcm_dma_params in
+	 * davinci_pcm_open.
+	 */

Which is doable.

Do you still want this fixed?

Thanks
Troy