alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Iwai <tiwai@suse.de>,
	Honza Maly <jmal8295@artax.karlin.mff.cuni.cz>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-cvslog] alsa-kernel: Official ALSA project GIT repository for Linux 2.6 branch, master now at v2.6.31-rc8-407-gfc9e4a3
Date: Thu, 08 Oct 2009 13:19:07 +0200	[thread overview]
Message-ID: <4ACDCAAB.2060609@ladisch.de> (raw)
In-Reply-To: <s5h4oqdrlys.wl%tiwai@suse.de>

jmal8295 wrote:
> And I _will_ be regarding it as regression if I lose possibility to
> change volume of the four streams independently.

Okay, as long as there is no application to handle PCM-interface
controls, the DXS controls should not be hidden this way.

Anyway, the volume level regression can be solved by any renaming, so
let's do just that.  Takashi, please pick the patch below instead.

==========

sound: via82xx: rename DXS volume controls

Only some insiders know what the "VIA DXS" controls actually control, so
change them to a more descriptive name.

Commit b452e08e73c0e3dbb0be82130217be4b7084299e in 2.6.30 broke the
restoring of these volumes by "alsactl restore" that most distributions
use; the renaming in this patch cures that regression by preventing
alsactl from applying the old, wrong volume levels to the new controls.
http://bugzilla.kernel.org/show_bug.cgi?id=14151
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=532613

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Cc: <stable@kernel.org>

--- a/sound/pci/via82xx.c
+++ b/sound/pci/via82xx.c
@@ -1705,7 +1705,7 @@
 };
 
 static struct snd_kcontrol_new snd_via8233_dxs_volume_control __devinitdata = {
-	.name = "VIA DXS Playback Volume",
+	.name = "PCM Stream Playback Volume",
 	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
 	.access = (SNDRV_CTL_ELEM_ACCESS_READWRITE |
 		   SNDRV_CTL_ELEM_ACCESS_TLV_READ),

  reply	other threads:[~2009-10-08 11:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20091006063609.B06E110381F@alsa0.perex.cz>
2009-10-06  7:03 ` [alsa-cvslog] alsa-kernel: Official ALSA project GIT repository for Linux 2.6 branch, master now at v2.6.31-rc8-407-gfc9e4a3 Takashi Iwai
2009-10-06  7:41   ` Clemens Ladisch
2009-10-06  8:00     ` Takashi Iwai
2009-10-08 11:19       ` Clemens Ladisch [this message]
2009-10-08 12:15         ` Takashi Iwai
2009-10-08 12:37           ` Clemens Ladisch
2009-10-08 18:11             ` Takashi Iwai
2010-02-24  9:16             ` Clemens Ladisch
2010-02-25 11:22               ` Raymond Yau
2010-02-25 23:52               ` Raymond Yau
2009-10-06 18:11     ` jmal8295
2009-10-07  6:31       ` Clemens Ladisch
2009-10-07  7:07         ` jmal8295
2009-10-07  7:59           ` Clemens Ladisch
2009-10-06  7:42   ` Jaroslav Kysela
2009-10-06  7:53     ` Clemens Ladisch
2009-10-06  8:27       ` Jaroslav Kysela
2009-10-06  8:30         ` Clemens Ladisch
2009-10-06  8:39           ` Jaroslav Kysela
2009-10-06 13:10             ` Jaroslav Kysela
2009-10-06  8:04     ` Takashi Iwai
2009-10-06  9:31   ` Ozan Çağlayan
2009-10-06 10:11     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACDCAAB.2060609@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jmal8295@artax.karlin.mff.cuni.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).