From: "Ozan Çağlayan" <ozan@pardus.org.tr>
To: alsa-devel@alsa-project.org
Cc: "tiwa >> Takashi Iwai" <tiwai@suse.de>
Subject: CONFIG_GCD is never defined in the latest alsa-driver
Date: Sat, 26 Dec 2009 12:55:24 +0200 [thread overview]
Message-ID: <4B35EB9C.9030501@pardus.org.tr> (raw)
Hi,
Compiling the latest alsa-driver with kernel > 2.6.31 results in gcd()
symbol duplication. Although there's a check in configure for
linux/gcd.h, no boolean is adjusted according to that.
In acore/wrappers.c, gcd() is exported if CONFIG_GCD is not defined
which seems always the case for now.
Something like the following fixes the problem for me:
Index: alsa-driver/acore/wrappers.c
===================================================================
--- alsa-driver.orig/acore/wrappers.c
+++ alsa-driver/acore/wrappers.c
@@ -339,7 +339,7 @@ char *compat_skip_spaces(const char *str
EXPORT_SYMBOL(compat_skip_spaces);
#endif /* < 2.6.33 */
-#ifndef CONFIG_GCD
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 31)
/* Greatest common divisor */
unsigned long gcd(unsigned long a, unsigned long b)
{
@@ -356,4 +356,4 @@ unsigned long gcd(unsigned long a, unsig
return b;
}
EXPORT_SYMBOL(gcd);
-#endif /* !CONFIG_GCD */
+#endif
Thanks!
next reply other threads:[~2009-12-26 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-26 10:55 Ozan Çağlayan [this message]
2009-12-26 10:58 ` CONFIG_GCD is never defined in the latest alsa-driver Ozan Çağlayan
2009-12-26 11:36 ` Takashi Iwai
2009-12-26 12:04 ` Ozan Çağlayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B35EB9C.9030501@pardus.org.tr \
--to=ozan@pardus.org.tr \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox