alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Valentin Longchamp <valentin.longchamp@epfl.ch>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	lrg@slimlogic.co.uk
Subject: Re: [PATCH 3/3] imx-ssi: Use a hrtimer in FIQ mode
Date: Thu, 08 Apr 2010 17:29:29 +0200	[thread overview]
Message-ID: <4BBDF659.1080407@epfl.ch> (raw)
In-Reply-To: <1270719086-23453-4-git-send-email-s.hauer@pengutronix.de>

Sascha Hauer wrote:
> Using a regular timer results in poll times < 1 jiffie with small
> buffers, so we loaded the timer with the actual jiffie value. We can
> be more accurate using a hrtimer. Also, we have to call
> snd_pcm_period_elapsed after playing period_bytes and not
> runtime->period_size (which is in samples and not in bytes).
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  sound/soc/imx/imx-pcm-fiq.c |   45 ++++++++++++++++++++----------------------
>  1 files changed, 21 insertions(+), 24 deletions(-)
> 

Sorry to bother you guys in your discussion (most of which I don't 
understand because of my poor alsa knowledge).

I just wanted to tell that I have given this patch a spin on a 
mx31moboard system. imx-ssi now works much better (the audio does not 
loop on one buffer anymore as it did with the earlier timer version) in 
various configuration (speaker-test with various rates up to 48 kHz as 
well as aplay with a wav file, which had never worked for me) and the 
CPU usage is much lower BUT I have experienced some deadlocks completely 
hanging the system looping on what should be the last buffer of the wave 
file.

Val

-- 
Valentin Longchamp, PhD Student, EPFL-STI-LSRO1
valentin.longchamp@epfl.ch, Phone: +41216937827
http://people.epfl.ch/valentin.longchamp
MEB3494, Station 9, CH-1015 Lausanne

  parent reply	other threads:[~2010-04-08 15:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08  9:31 imx-ssi fixes Sascha Hauer
2010-04-08  9:31 ` [PATCH 1/3] imx-ssi: honor IMX_SSI_DMA flag Sascha Hauer
2010-04-08  9:31 ` [PATCH 2/3] imx-pcm-dma-mx2: restart DMA after an error Sascha Hauer
2010-04-08  9:31 ` [PATCH 3/3] imx-ssi: Use a hrtimer in FIQ mode Sascha Hauer
2010-04-08  9:53   ` Mark Brown
2010-04-08 13:13     ` Sascha Hauer
2010-04-08 13:30       ` Liam Girdwood
2010-04-08 15:40         ` Sascha Hauer
2010-04-08 14:03       ` Mark Brown
2010-04-08 15:14         ` Liam Girdwood
2010-04-08 15:45           ` Mark Brown
2010-04-08 15:29   ` Valentin Longchamp [this message]
2010-04-08 14:47 ` imx-ssi fixes Mark Brown
2010-04-08 15:51   ` Sascha Hauer
2010-04-08 15:54     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBDF659.1080407@epfl.ch \
    --to=valentin.longchamp@epfl.ch \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).