From: Clemens Ladisch <clemens@ladisch.de>
To: Hector Martin <hector@marcansoft.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa-python: add register_poll to alsaseq
Date: Wed, 21 Apr 2010 08:52:44 +0200 [thread overview]
Message-ID: <4BCEA0BC.3060905@ladisch.de> (raw)
In-Reply-To: <4BCE7868.1020108@marcansoft.com>
Hector Martin wrote:
> Attached patch adds register_poll to the sequencer bindings to support
> nonblocking sequencer access with the select module.
>
> From db1a07ad9e9076f258d1ff871955eedc7d34ae9c Mon Sep 17 00:00:00 2001
> From: Hector Martin <hector@marcansoft.com>
> Date: Wed, 21 Apr 2010 05:54:49 +0200
> Subject: [PATCH] Add register_poll for alsaseq
>
> ---
> pyalsa/alsaseq.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 53 insertions(+), 0 deletions(-)
Please provide a Signed-off-by tag; we use this also for non-kernel code.
> + pfd = malloc(sizeof(struct pollfd) * count);
This isn't freed; better use alloca().
Regards,
Clemens
next prev parent reply other threads:[~2010-04-21 6:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 4:00 [PATCH] alsa-python: add register_poll to alsaseq Hector Martin
2010-04-21 6:52 ` Clemens Ladisch [this message]
2010-04-21 14:05 ` Hector Martin
-- strict thread matches above, loose matches on Subject: below --
2010-05-12 1:51 Hector Martin
2010-05-27 8:20 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCEA0BC.3060905@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=hector@marcansoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox