From: John Lindgren <john.lindgren@tds.net>
To: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org
Subject: Re: Small memory leak in snd_pcm_ladspa_init()
Date: Wed, 21 Jul 2010 22:32:51 -0400 [thread overview]
Message-ID: <4C47ADD3.6070205@tds.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1007220013050.9258@eeebox2.perex-int.cz>
Yes, that fixes it. Thank you.
-- John
On 07/21/2010 06:13 PM, Jaroslav Kysela wrote:
> Does this patch help?
>
> diff --git a/src/pcm/pcm_ladspa.c b/src/pcm/pcm_ladspa.c
> index 5161820..c413c10 100644
> --- a/src/pcm/pcm_ladspa.c
> +++ b/src/pcm/pcm_ladspa.c
> @@ -341,6 +341,8 @@ static void snd_pcm_ladspa_free_instances(snd_pcm_t *pcm, snd_pcm_ladspa_t *lads
> free(instance->output.m_data[idx]);
> free(instance->output.m_data);
> }
> + free(instance->input.data);
> + free(instance->output.data);
> list_del(&(instance->list));
> snd_pcm_ladspa_free_eps(&instance->input);
> snd_pcm_ladspa_free_eps(&instance->output);
>
> -----
> Jaroslav Kysela <perex@perex.cz>
> Linux Kernel Sound Maintainer
> ALSA Project, Red Hat, Inc.
>
prev parent reply other threads:[~2010-07-22 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 15:48 Small memory leak in snd_pcm_ladspa_init() John Lindgren
2010-07-21 22:13 ` Jaroslav Kysela
2010-07-22 2:32 ` John Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C47ADD3.6070205@tds.net \
--to=john.lindgren@tds.net \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox