alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Felix Homann <fexpop@web.de>
To: Felix Homann <fexpop@web.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH - Fix Fast Track Ultra series: 44.1/88.1 kHz 1/Fix playback/capture issues and related chrashes at 44100 Hz and 88200 Hz for M-Audio Fast Track Ultra series.
Date: Tue, 31 Aug 2010 08:39:24 +0200	[thread overview]
Message-ID: <4C7CA39C.60205@web.de> (raw)
In-Reply-To: <4C32E3B2.5080707@web.de>

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

Dear Alsa developers,

almost 2 months ago I send a patch making the M-Audio Fast Track Ultra 
series audio interfaces work flawlessly in Linux except for missing 
mixer support:

Am 06.07.2010 10:05, schrieb Felix Homann:
> This fixes issues with M-Audio's Fast Track Ultra series:
>
> * devices now work at 44100 and 88200 Hz
> * apparently, fixes some crashes, too

Unfortunately, the patch didn't make it into Alsa so far. Clemens 
Ladisch seemed reluctant to apply a fixed endpoint quirk since the 
device should have worked without in his opinion. I gave him all the 
requested information to see what was happening without the fixed 
endpoint quirk. I never heard back from him again.

So, could someone in charge kindly tell me why the patch didn't make it 
into Alsa? What's missing, what's wrong?

If it's just the fact that Clemens doesn't like the fixed endpoint quirk 
please find attached a different patch yielding the same result. 
(Against Linux 2.6.35. It's again from dhubsith who posted it on the 
M-Audio forum. He would sign it off if requested - on the other hand it 
is already derived work of the Alsa sources).

And please, if it's not going anywhere, please tell us "laymen, 
volunteer Alsa helpers" about the reasons.

The current situation is most frustrating: We know how to make the 
device work (much better than in Windows, btw) but we don't know why we 
have to patch alsa again and again.

Thanks in advance,

Felix



[-- Attachment #2: maudio.patch-2.6.35.txt --]
[-- Type: text/plain, Size: 2812 bytes --]

diff -rupN /sound/usb/card.c /sound/usb/card.c
--- /sound/usb/card.c
+++ /sound/usb/card.c
@@ -209,6 +209,8 @@ static int snd_usb_create_streams(struct
 						 NULL, UAC_HEADER);
 	altsd = get_iface_desc(host_iface);
 	protocol = altsd->bInterfaceProtocol;
+                if (chip->usb_id == USB_ID(0x0763, 0x2080) || chip->usb_id == USB_ID(0x0763, 0x2081))
+		protocol = UAC_VERSION_1;
 
 	if (!control_header) {
 		snd_printk(KERN_ERR "cannot find UAC_HEADER\n");
diff -rupN /sound/usb/endpoint.c /sound/usb/endpoint.c
--- /sound/usb/endpoint.c
+++ /sound/usb/endpoint.c
@@ -252,6 +252,8 @@ int snd_usb_parse_audio_endpoints(struct
 		alts = &iface->altsetting[i];
 		altsd = get_iface_desc(alts);
 		protocol = altsd->bInterfaceProtocol;
+                if (chip->usb_id == USB_ID(0x0763, 0x2080) || chip->usb_id == USB_ID(0x0763, 0x2081))
+		protocol = UAC_VERSION_1;
 		/* skip invalid one */
 		if ((altsd->bInterfaceClass != USB_CLASS_AUDIO &&
 		     altsd->bInterfaceClass != USB_CLASS_VENDOR_SPEC) ||
@@ -403,11 +405,15 @@ int snd_usb_parse_audio_endpoints(struct
 			break;
 		case USB_ID(0x041e, 0x3020): /* Creative SB Audigy 2 NX */
 		case USB_ID(0x0763, 0x2003): /* M-Audio Audiophile USB */
-		case USB_ID(0x0763, 0x2080): /* M-Audio Fast Track Ultra 8 */
-		case USB_ID(0x0763, 0x2081): /* M-Audio Fast Track Ultra 8R */
 			/* doesn't set the sample rate attribute, but supports it */
 			fp->attributes |= UAC_EP_CS_ATTR_SAMPLE_RATE;
 			break;
+		case USB_ID(0x0763, 0x2080): /* M-Audio Fast Track Ultra   */
+		case USB_ID(0x0763, 0x2081): /* M-Audio Fast Track Ultra 8R */
+			/* force playback sync to adaptive only and turn off async*/
+			if (stream == SNDRV_PCM_STREAM_PLAYBACK)
+				fp->ep_attr = 0x09;
+			break;
 		case USB_ID(0x047f, 0x0ca1): /* plantronics headset */
 		case USB_ID(0x077d, 0x07af): /* Griffin iMic (note that there is
 						an older model 77d:223) */
diff -rupN /sound/usb/format.c /sound/usb/format.c
--- /sound/usb/format.c
+++ /sound/usb/format.c
@@ -353,6 +353,8 @@ static int parse_audio_format_i(struct s
 	struct usb_interface_descriptor *altsd = get_iface_desc(iface);
 	int protocol = altsd->bInterfaceProtocol;
 	int pcm_format, ret;
+                if (chip->usb_id == USB_ID(0x0763, 0x2080) || chip->usb_id == USB_ID(0x0763, 0x2081))
+		protocol = UAC_VERSION_1;
 
 	if (fmt->bFormatType == UAC_FORMAT_TYPE_III) {
 		/* FIXME: the format type is really IECxxx
@@ -415,6 +417,8 @@ static int parse_audio_format_ii(struct 
 	int brate, framesize, ret;
 	struct usb_interface_descriptor *altsd = get_iface_desc(iface);
 	int protocol = altsd->bInterfaceProtocol;
+                if (chip->usb_id == USB_ID(0x0763, 0x2080) || chip->usb_id == USB_ID(0x0763, 0x2081))
+		protocol = UAC_VERSION_1;
 
 	switch (format) {
 	case UAC_FORMAT_TYPE_II_AC3:

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2010-08-31  6:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-06  8:05 [PATCH - Fix Fast Track Ultra series: 44.1/88.1 kHz 1/Fix playback/capture issues and related chrashes at 44100 Hz and 88200 Hz for M-Audio Fast Track Ultra series Felix Homann
2010-07-07  9:05 ` Felix Homann
2010-07-07 12:44   ` Clemens Ladisch
2010-07-07 13:19     ` Felix Homann
2010-07-07 13:59       ` Felix Homann
2010-07-07 14:23       ` Clemens Ladisch
2010-07-07 16:55         ` Felix Homann
2010-07-08  6:25           ` Clemens Ladisch
2010-07-08  8:35             ` Felix Homann
2010-07-08 13:10               ` Clemens Ladisch
2010-07-08 15:14                 ` Felix Homann
2010-07-08 15:19                   ` Clemens Ladisch
2010-07-08 15:54                     ` Felix Homann
2010-07-16  8:27         ` Felix Homann
2010-08-31  6:39 ` Felix Homann [this message]
2010-08-31  8:24   ` [PATCH] - Fix Fast Track Ultra series: 44.1/88.1 kHz 1/Fix playback/capture issues and related crashes " Paul Menzel
2010-09-01  8:48 ` [RESENT] [PATCH - Fix Fast Track Ultra series: 44.1/88.1 kHz 1/Fix playback/capture issues and related chrashes " Felix Homann
2010-09-02  8:33   ` Takashi Iwai
2010-09-02  9:12     ` Clemens Ladisch
2010-09-02  9:16       ` Daniel Mack
2010-09-02 11:13         ` Clemens Ladisch
2010-09-03 13:34           ` Daniel Mack
2010-09-03 14:26             ` Clemens Ladisch
2010-09-02 10:12       ` Felix Homann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7CA39C.60205@web.de \
    --to=fexpop@web.de \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).