* tlv320aic3x: potential null dereference
@ 2010-09-04 13:07 Jiri Slaby
2010-09-05 15:46 ` Jarkko Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2010-09-04 13:07 UTC (permalink / raw)
To: lrg; +Cc: alsa-devel, LKML
Hi,
stanse found a potential null dereference:
aic3x_i2c_probe
-> struct aic3x_setup_data *setup = pdata->setup;
-> -- pdata can't be null now--
-> if (pdata && pdata->gpio_reset >= 0)
But there is another check for pdata == NULL. Could take a look and fix
it (either remove the check or move the assignement inside the if)?
thanks,
--
js
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: tlv320aic3x: potential null dereference
2010-09-04 13:07 tlv320aic3x: potential null dereference Jiri Slaby
@ 2010-09-05 15:46 ` Jarkko Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Nikula @ 2010-09-05 15:46 UTC (permalink / raw)
To: Jiri Slaby; +Cc: alsa-devel, LKML, lrg
On Sat, 04 Sep 2010 15:07:57 +0200
Jiri Slaby <jirislaby@gmail.com> wrote:
> Hi,
>
> stanse found a potential null dereference:
> aic3x_i2c_probe
> -> struct aic3x_setup_data *setup = pdata->setup;
> -> -- pdata can't be null now--
> -> if (pdata && pdata->gpio_reset >= 0)
>
> But there is another check for pdata == NULL. Could take a look and fix
> it (either remove the check or move the assignement inside the if)?
>
Thanks, this is a bug that got introduced recently to ASoC tree.
Fortunately is not in mainline. I'll send a fix in a minute to
alsa-devel.
--
Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-05 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-04 13:07 tlv320aic3x: potential null dereference Jiri Slaby
2010-09-05 15:46 ` Jarkko Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).