From: Ryan Mallon <ryan@bluewatersys.com>
To: Mika Westerberg <mika.westerberg@iki.fi>
Cc: alsa-devel@alsa-project.org, martinwguy@gmail.com,
broonie@opensource.wolfsonmicro.com,
hsweeten@visionengravers.com,
linux-arm-kernel@lists.infradead.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH v3 2/3] ARM: ep93xx: add AC97 platform support
Date: Fri, 15 Oct 2010 08:56:18 +1300 [thread overview]
Message-ID: <4CB76062.3020904@bluewatersys.com> (raw)
In-Reply-To: <14a8c7ea0482375fa32a022ea7e318ea4feae6f1.1287066937.git.mika.westerberg@iki.fi>
On 10/15/2010 03:49 AM, Mika Westerberg wrote:
> Add platform support for the EP93xx AC97 controller driver.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
> ---
> arch/arm/mach-ep93xx/core.c | 34 +++++++++++++++++++++++
> arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h | 1 +
> arch/arm/mach-ep93xx/include/mach/platform.h | 1 +
> 3 files changed, 36 insertions(+), 0 deletions(-)
Looks good.
Acked-by: Ryan Mallon <ryan@bluewatersys.com>
> diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
> index 1990e22..ffdf87b 100644
> --- a/arch/arm/mach-ep93xx/core.c
> +++ b/arch/arm/mach-ep93xx/core.c
> @@ -832,6 +832,40 @@ void ep93xx_i2s_release(void)
> }
> EXPORT_SYMBOL(ep93xx_i2s_release);
>
> +/*************************************************************************
> + * EP93xx AC97 audio peripheral handling
> + *************************************************************************/
> +static struct resource ep93xx_ac97_resources[] = {
> + {
> + .start = EP93XX_AAC_PHYS_BASE,
> + .end = EP93XX_AAC_PHYS_BASE + 0xb0 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + {
> + .start = IRQ_EP93XX_AACINTR,
> + .end = IRQ_EP93XX_AACINTR,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +static struct platform_device ep93xx_ac97_device = {
> + .name = "ep93xx-ac97",
> + .id = -1,
> + .num_resources = ARRAY_SIZE(ep93xx_ac97_resources),
> + .resource = ep93xx_ac97_resources,
> +};
> +
> +void __init ep93xx_register_ac97(void)
> +{
> + /*
> + * Make sure that the AC97 pins are not used by I2S.
> + */
> + ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_I2SONAC97);
> +
> + platform_device_register(&ep93xx_ac97_device);
> + platform_device_register(&ep93xx_pcm_device);
> +}
> +
> extern void ep93xx_gpio_init(void);
>
> void __init ep93xx_init_devices(void)
> diff --git a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
> index c54b3e5..9ac4d10 100644
> --- a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
> +++ b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
> @@ -105,6 +105,7 @@
> #define EP93XX_GPIO_B_INT_STATUS EP93XX_GPIO_REG(0xbc)
> #define EP93XX_GPIO_EEDRIVE EP93XX_GPIO_REG(0xc8)
>
> +#define EP93XX_AAC_PHYS_BASE EP93XX_APB_PHYS(0x00080000)
> #define EP93XX_AAC_BASE EP93XX_APB_IOMEM(0x00080000)
>
> #define EP93XX_SPI_PHYS_BASE EP93XX_APB_PHYS(0x000a0000)
> diff --git a/arch/arm/mach-ep93xx/include/mach/platform.h b/arch/arm/mach-ep93xx/include/mach/platform.h
> index 3330b36..5066045 100644
> --- a/arch/arm/mach-ep93xx/include/mach/platform.h
> +++ b/arch/arm/mach-ep93xx/include/mach/platform.h
> @@ -61,6 +61,7 @@ void ep93xx_keypad_release_gpio(struct platform_device *pdev);
> void ep93xx_register_i2s(void);
> int ep93xx_i2s_acquire(unsigned i2s_pins, unsigned i2s_config);
> void ep93xx_i2s_release(void);
> +void ep93xx_register_ac97(void);
>
> void ep93xx_init_devices(void);
> extern struct sys_timer ep93xx_timer;
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2010-10-14 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 14:49 [PATCH v3 0/3] ASoC AC97 audio support for ep93xx Mika Westerberg
2010-10-14 14:49 ` [PATCH v3 1/3] ASoC: add ep93xx AC97 audio driver Mika Westerberg
2010-10-14 14:49 ` [PATCH v3 2/3] ARM: ep93xx: add AC97 platform support Mika Westerberg
2010-10-14 19:56 ` Ryan Mallon [this message]
2010-10-14 21:46 ` H Hartley Sweeten
2010-10-14 21:57 ` Ryan Mallon
2010-10-14 22:07 ` H Hartley Sweeten
2010-10-14 14:49 ` [PATCH v3 3/3] ASoC: ep93xx: add Simplemachines Sim.One AC97 audio support Mika Westerberg
2010-10-15 9:57 ` [PATCH v3 0/3] ASoC AC97 audio support for ep93xx Liam Girdwood
2010-10-15 10:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB76062.3020904@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
--cc=martinwguy@gmail.com \
--cc=mika.westerberg@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox