From: Clemens Ladisch <clemens@ladisch.de>
To: Julia Lawall <julia@diku.dk>
Cc: tiwai@suse.de, tj@kernel.org, alsa-devel@alsa-project.org
Subject: Re: question about sound/pci/ctxfi/ctpcm.c
Date: Tue, 09 Nov 2010 12:03:07 +0100 [thread overview]
Message-ID: <4CD92A6B.8010702@ladisch.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1011090923490.25928@ask.diku.dk>
Julia Lawall wrote:
> [...] One option would be to move the
> initializations downwards, since the intervening calls that use runtime
> don't use those fields. The other would be to set provate_data to NULL
> after doing the free. Any preference?
I notice that ct_atc_pcm_free_substream does not expect private_data to
be NULL, so only the first option would work. Furthermore, apcm->timer
must not be NULL, so the initialization must be moved to the end of the
function.
Regards,
Clemens
next prev parent reply other threads:[~2010-11-09 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 16:58 question about sound/pci/ctxfi/ctpcm.c Julia Lawall
2010-11-09 8:07 ` Clemens Ladisch
2010-11-09 8:25 ` Julia Lawall
2010-11-09 11:03 ` Clemens Ladisch [this message]
2010-11-09 11:03 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD92A6B.8010702@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=julia@diku.dk \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).