From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] ASoC: soc-cache: Use reg_def_copy instead of reg_cache_default
Date: Thu, 6 Jan 2011 10:26:43 -0600 [thread overview]
Message-ID: <4D25ED43.9010701@freescale.com> (raw)
In-Reply-To: <20110106003455.GA12153@opensource.wolfsonmicro.com>
Mark Brown wrote:
> So ask that question; "I looked at this and I'm not really sure if it's
> supposed to work or not - thing X suggests yes, thing Y suggests no but
> looks like a bug so..." and so on.
>
> In cases like this (although not I suspect this particular one) the
> answer is often that there was't any particular consideration for
> whatever unusual case you're looking at.
Ah, but I don't think my case is "unusual". Frankly, I think it's unusual to
hard-code default register values into a driver. I just don't see how you can
guarantee that the values will be correct for all supported revisions of the chip.
On the CS4270, for instance, one register contains the chip revision number.
There's no way I can know which revision will be used on any given board.
Anyway, I'll work on fixing this and post a patch.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-01-06 16:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 16:11 [PATCH 0/2] ASoC: Override codec compress_type from the machine driver Dimitris Papastamos
2010-12-02 16:11 ` [PATCH 1/2] ASoC: soc-cache: Use reg_def_copy instead of reg_cache_default Dimitris Papastamos
2011-01-05 21:04 ` Timur Tabi
2011-01-05 23:03 ` Mark Brown
2011-01-05 23:08 ` Timur Tabi
2011-01-05 23:29 ` Mark Brown
2011-01-05 23:51 ` Mark Brown
2011-01-06 0:15 ` Tabi Timur-B04825
2011-01-06 0:34 ` Mark Brown
2011-01-06 16:26 ` Timur Tabi [this message]
2011-01-06 21:20 ` Mark Brown
2011-01-06 16:53 ` Dimitris Papastamos
2011-01-06 17:01 ` Timur Tabi
2010-12-02 16:11 ` [PATCH 2/2] ASoC: soc-core: Allow machine drivers to override compress_type Dimitris Papastamos
2010-12-03 16:14 ` [PATCH 0/2] ASoC: Override codec compress_type from the machine driver Liam Girdwood
2010-12-03 16:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D25ED43.9010701@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).