From: Timur Tabi <timur@freescale.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] ASoC: soc-cache: Use reg_def_copy instead of reg_cache_default
Date: Thu, 6 Jan 2011 11:01:30 -0600 [thread overview]
Message-ID: <4D25F56A.5060903@freescale.com> (raw)
In-Reply-To: <1294332806.19933.5.camel@dplaptop.localdomain>
Dimitris Papastamos wrote:
> The semantics behind this code is that if the driver provides a
> reg_cache_size and a reg_word_size it *should* provide a defaults
> register cache as well.
I *had* code which did this, but apparently it broke somewhere. Oh well.
> If you want to manage your own register cache
> in the driver which is not advised, you will have to add similar
> functionality in your _priv struct. If you require more flexible
> functionality you need to consider implementing a sensible strategy and
> submitting it as a patch.
I will fix my driver to restore the functionality.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-01-06 17:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 16:11 [PATCH 0/2] ASoC: Override codec compress_type from the machine driver Dimitris Papastamos
2010-12-02 16:11 ` [PATCH 1/2] ASoC: soc-cache: Use reg_def_copy instead of reg_cache_default Dimitris Papastamos
2011-01-05 21:04 ` Timur Tabi
2011-01-05 23:03 ` Mark Brown
2011-01-05 23:08 ` Timur Tabi
2011-01-05 23:29 ` Mark Brown
2011-01-05 23:51 ` Mark Brown
2011-01-06 0:15 ` Tabi Timur-B04825
2011-01-06 0:34 ` Mark Brown
2011-01-06 16:26 ` Timur Tabi
2011-01-06 21:20 ` Mark Brown
2011-01-06 16:53 ` Dimitris Papastamos
2011-01-06 17:01 ` Timur Tabi [this message]
2010-12-02 16:11 ` [PATCH 2/2] ASoC: soc-core: Allow machine drivers to override compress_type Dimitris Papastamos
2010-12-03 16:14 ` [PATCH 0/2] ASoC: Override codec compress_type from the machine driver Liam Girdwood
2010-12-03 16:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D25F56A.5060903@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).