HDA - hdmi_show_short_audio_desc puts wrong rates in eld#N

HDA - hdmi_show_short_audio_desc puts wrong rates in eld#N

[Anssi Hannula]

Hi!

Just noticed that the sample rates reported in eld#X.Y are wrong.

They are printed by hdmi_show_short_audio_desc() in hda_eld.c. That
function uses the snd_print_pcm_rates() function to convert the rates
bitmap to a string. However, snd_print_pcm_rates() takes a HDA rates
bitmap, not a generic SNDRV_ one.  (BTW, an interesting function name
for an internal HDA thing...)

This results in several errors.

For example, my 32000 44100 48000 88200 96000 176400 192000
becomes 44100 48000 88200 176400 192000 384000.

-- 
Anssi Hannula

Re: HDA - hdmi_show_short_audio_desc puts wrong rates in eld#N

[Anssi Hannula]

On 07.12.2010 13:01, Anssi Hannula wrote:
> Hi!
> 
> Just noticed that the sample rates reported in eld#X.Y are wrong.
> 
> They are printed by hdmi_show_short_audio_desc() in hda_eld.c. That
> function uses the snd_print_pcm_rates() function to convert the rates
> bitmap to a string. However, snd_print_pcm_rates() takes a HDA rates
> bitmap, not a generic SNDRV_ one.  (BTW, an interesting function name
> for an internal HDA thing...)
> 
> This results in several errors.
> 
> For example, my 32000 44100 48000 88200 96000 176400 192000
> becomes 44100 48000 88200 176400 192000 384000.

In case I write a patch for this, is there a preferred approach?

(a) Add a function into alsa core that returns such a list string when
given a rates bitmap, or

(b) export the rates array in core and make the string-giving function a
static one for hda_eld.c, or

(c) add a static function into hda_eld.c that parses the bitmap manually
by checking it for all the hdmi rates (7 IIRC).

-- 
Anssi Hannula