From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: matti.j.aaltonen@nokia.com, alsa-devel@alsa-project.org,
lrg@slimlogic.co.uk, hverkuil@xs4all.nl, sameo@linux.intel.com,
linux-media@vger.kernel.org
Subject: Re: WL1273 FM Radio driver...
Date: Mon, 07 Feb 2011 10:48:03 -0200 [thread overview]
Message-ID: <4D4FEA03.7090109@redhat.com> (raw)
In-Reply-To: <20110207120234.GE10564@opensource.wolfsonmicro.com>
Em 07-02-2011 10:02, Mark Brown escreveu:
> On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab wrote:
>
>> the MFD part (for example, wl1273_fm_read_reg/wl1273_fm_write_cmd/wl1273_fm_write_data).
>> The logic that are related to control the radio (wl1273_fm_set_audio, wl1273_fm_set_volume,
>> etc) are not related to access the device via the MFD bus. They should be at
>> the media part of the driver, where they belong.
>
> Those functions are being used by the audio driver.
Not sure if I understood your comments. Several media drivers have alsa drivers:
saa7134, em28xx, cx231xx, etc. The audio drivers for them are also under
/drivers/media, as it is not easy to de-couple audio and video/radio part
on those devices. For bttv and some USB boards (that use snd-usb-audio), the audio
part is at /sound, as the audio part on them are independent and don't need to
share anything, as audio is provided by a completely independent group of
registers.
I suggest to use the same logic for wl1273.
Cheers,
Mauro.
next prev parent reply other threads:[~2011-02-07 12:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 10:52 WL1273 FM Radio driver Matti J. Aaltonen
2011-02-07 12:00 ` Mauro Carvalho Chehab
2011-02-07 12:02 ` Mark Brown
2011-02-07 12:48 ` Mauro Carvalho Chehab [this message]
2011-02-07 13:10 ` Mark Brown
2011-02-07 13:48 ` Mauro Carvalho Chehab
2011-02-07 13:52 ` Mark Brown
2011-02-07 14:17 ` Matti J. Aaltonen
2011-02-07 16:00 ` Mauro Carvalho Chehab
2011-02-08 9:15 ` Peter Ujfalusi
2011-02-08 10:09 ` [alsa-devel] " Bensaid, Selma
2011-02-08 11:02 ` Peter Ujfalusi
2011-02-08 13:47 ` [alsa-devel] " Bensaid, Selma
2011-02-09 7:14 ` Matti J. Aaltonen
2011-02-09 7:22 ` Matti J. Aaltonen
2011-02-10 9:35 ` Bensaid, Selma
2011-02-10 10:03 ` Matti J. Aaltonen
2011-02-10 11:02 ` [alsa-devel] " Mark Brown
2011-02-10 12:10 ` Matti J. Aaltonen
2011-02-10 12:28 ` Mark Brown
2011-02-10 12:57 ` Matti J. Aaltonen
2011-02-10 13:23 ` [alsa-devel] " Mark Brown
2011-02-09 7:27 ` Matti J. Aaltonen
2011-02-09 8:47 ` Matti J. Aaltonen
2011-02-07 14:09 ` Matti J. Aaltonen
2011-02-07 15:57 ` Mauro Carvalho Chehab
2011-02-07 16:01 ` Mark Brown
2011-02-07 13:27 ` Matti J. Aaltonen
2011-02-07 13:28 ` Mark Brown
2011-02-07 13:34 ` Matti J. Aaltonen
-- strict thread matches above, loose matches on Subject: below --
2011-01-18 15:04 Matti J. Aaltonen
2011-01-19 10:18 ` Mark Brown
2011-01-30 23:23 ` Samuel Ortiz
2011-02-02 15:35 ` Mauro Carvalho Chehab
2011-02-02 15:51 ` Mark Brown
2011-02-03 0:37 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4FEA03.7090109@redhat.com \
--to=mchehab@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=matti.j.aaltonen@nokia.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).