pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

[Wolfgang Scheicher]

After the mentioned Kernel upgrade quite a view things went wrong on my 
hardware ( http://www.asrock.com/mb/overview.asp?Model=890GM%20Pro3 ):

* Microphone doesn't work anymore. neither the front mic nor the rear one. 
Tried all thinkable settings.

* Increasing Microphone levels leads to some strange internal feedback. That 
means, at some point when the feedback starts, it just starts, but i have no 
clue what audio source did actually trigger it.

* Touching the mixer channel "Smart 5.1" in alsamixer makes alsamicer crash.


After quite some days of frustration and the inability to get help i however 
managed to learn how to build a kernel and how to git bisect. So this is 
what i did:


root@Blackrock ~src/alsa-kernel (git)-[7b315bb...|bisect] # git bisect log
git bisect start '--' 'sound/pci'
# bad: [81a2f603f94d6da108ddd8e3535294445097f730] ALSA: ac97: replace open-
coded, error-prone stuff with AC97 bit defines
git bisect bad 81a2f603f94d6da108ddd8e3535294445097f730
# good: [f6f94e2ab1b33f0082ac22d71f66385a60d8157f] Linux 2.6.36
git bisect good f6f94e2ab1b33f0082ac22d71f66385a60d8157f
# bad: [28c4edb71d21623f1e47422194d865d2b6712fd4] ALSA: HDA: Rename "Int 
Mic" to "Internal Mic"
git bisect bad 28c4edb71d21623f1e47422194d865d2b6712fd4
# bad: [0e7adbe263f89ea2ef15b5af5e80a812b2a85025] ALSA: hda - Disable sticky 
PCM stream assignment for AD codecs
git bisect bad 0e7adbe263f89ea2ef15b5af5e80a812b2a85025
# bad: [5637edb2e1c2d13b276748508ae17f319fb7f066] ALSA: HDA: Sort CXT5066 
quirk table
git bisect bad 5637edb2e1c2d13b276748508ae17f319fb7f066
# bad: [18675e4283f575594d55ef1239c14ab5b4de53b6] ALSA: hda - Add fixup for 
FSC Celsius H270
git bisect bad 18675e4283f575594d55ef1239c14ab5b4de53b6
# good: [eea7dc932bfa802ad0377755ea821f416f4f8623] ALSA: hda - Use new 
inputs[] field to parse input-pins for STAC/IDT codecs
git bisect good eea7dc932bfa802ad0377755ea821f416f4f8623
# bad: [263d0328c46995d8e4fb478005177839104483d2] ALSA: hda - Improve input 
control names for IDT/STAC codecs
git bisect bad 263d0328c46995d8e4fb478005177839104483d2
# bad: [9737731d64bfa64ab4fc04b46ae5b650f6432222] Merge branch 'fix/hda' 
into topic/hda
git bisect bad 9737731d64bfa64ab4fc04b46ae5b650f6432222
# bad: [7b315bb4980448250c80a7464c256b54d546cb26] ALSA: hda - Use new 
inputs[] field to parse input-pins for VIA codecs
git bisect bad 7b315bb4980448250c80a7464c256b54d546cb26


root@Blackrock ~src/alsa-kernel (git)-[7b315bb...|bisect] # git bisect bad
7b315bb4980448250c80a7464c256b54d546cb26 is the first bad commit
commit 7b315bb4980448250c80a7464c256b54d546cb26
Author: Takashi Iwai <tiwai@suse.de>
Date:   Mon Aug 30 13:06:30 2010 +0200

    ALSA: hda - Use new inputs[] field to parse input-pins for VIA codecs
    
    Signed-off-by: Takashi Iwai <tiwai@suse.de>

:040000 040000 fb32bef12d78f90f00020cf375fddd36be1cdfbe 
02f61291093ce6c7c8e7e1bd98fd87f9338702a1 M      sound



Oh, and here are debug infos from when i first tried to report the problem:
bad:
http://www.alsa-project.org/db/?f=0f29e6de98ea9fefae5c6e2adb43ff8f8eede697

good:
http://www.alsa-project.org/db/?f=11290fe50066e9bcd6a244f2c83b1c66c9dd201b


I hope someone can take it from here. I'm not much more than a user. Just 
because i managed to build a kernel doesn't mean i can fix this bug.

Wolfgang Scheicher

Re: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

[Mark Goldstein]

Hi,

On Sun, Feb 20, 2011 at 12:50 PM, Wolfgang Scheicher
<wolfgang.scheicher@gmail.com> wrote:
>
> After the mentioned Kernel upgrade quite a view things went wrong on my
> hardware ( http://www.asrock.com/mb/overview.asp?Model=890GM%20Pro3 ):
>
> * Microphone doesn't work anymore. neither the front mic nor the rear one.
> Tried all thinkable settings.
>
> * Increasing Microphone levels leads to some strange internal feedback. That
> means, at some point when the feedback starts, it just starts, but i have no
> clue what audio source did actually trigger it.
>
> * Touching the mixer channel "Smart 5.1" in alsamixer makes alsamicer crash.
>
>
> After quite some days of frustration and the inability to get help i however
> managed to learn how to build a kernel and how to git bisect. So this is
> what i did:
>
>
> root@Blackrock ~src/alsa-kernel (git)-[7b315bb...|bisect] # git bisect log
> git bisect start '--' 'sound/pci'
> # bad: [81a2f603f94d6da108ddd8e3535294445097f730] ALSA: ac97: replace open-
> coded, error-prone stuff with AC97 bit defines
> git bisect bad 81a2f603f94d6da108ddd8e3535294445097f730
> # good: [f6f94e2ab1b33f0082ac22d71f66385a60d8157f] Linux 2.6.36
> git bisect good f6f94e2ab1b33f0082ac22d71f66385a60d8157f
> # bad: [28c4edb71d21623f1e47422194d865d2b6712fd4] ALSA: HDA: Rename "Int
> Mic" to "Internal Mic"
> git bisect bad 28c4edb71d21623f1e47422194d865d2b6712fd4
> # bad: [0e7adbe263f89ea2ef15b5af5e80a812b2a85025] ALSA: hda - Disable sticky
> PCM stream assignment for AD codecs
> git bisect bad 0e7adbe263f89ea2ef15b5af5e80a812b2a85025
> # bad: [5637edb2e1c2d13b276748508ae17f319fb7f066] ALSA: HDA: Sort CXT5066
> quirk table
> git bisect bad 5637edb2e1c2d13b276748508ae17f319fb7f066
> # bad: [18675e4283f575594d55ef1239c14ab5b4de53b6] ALSA: hda - Add fixup for
> FSC Celsius H270
> git bisect bad 18675e4283f575594d55ef1239c14ab5b4de53b6
> # good: [eea7dc932bfa802ad0377755ea821f416f4f8623] ALSA: hda - Use new
> inputs[] field to parse input-pins for STAC/IDT codecs
> git bisect good eea7dc932bfa802ad0377755ea821f416f4f8623
> # bad: [263d0328c46995d8e4fb478005177839104483d2] ALSA: hda - Improve input
> control names for IDT/STAC codecs
> git bisect bad 263d0328c46995d8e4fb478005177839104483d2
> # bad: [9737731d64bfa64ab4fc04b46ae5b650f6432222] Merge branch 'fix/hda'
> into topic/hda
> git bisect bad 9737731d64bfa64ab4fc04b46ae5b650f6432222
> # bad: [7b315bb4980448250c80a7464c256b54d546cb26] ALSA: hda - Use new
> inputs[] field to parse input-pins for VIA codecs
> git bisect bad 7b315bb4980448250c80a7464c256b54d546cb26
>
>
> root@Blackrock ~src/alsa-kernel (git)-[7b315bb...|bisect] # git bisect bad
> 7b315bb4980448250c80a7464c256b54d546cb26 is the first bad commit
> commit 7b315bb4980448250c80a7464c256b54d546cb26
> Author: Takashi Iwai <tiwai@suse.de>
> Date:   Mon Aug 30 13:06:30 2010 +0200
>
>    ALSA: hda - Use new inputs[] field to parse input-pins for VIA codecs
>
>    Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
> :040000 040000 fb32bef12d78f90f00020cf375fddd36be1cdfbe
> 02f61291093ce6c7c8e7e1bd98fd87f9338702a1 M      sound
>
>
>
> Oh, and here are debug infos from when i first tried to report the problem:
> bad:
> http://www.alsa-project.org/db/?f=0f29e6de98ea9fefae5c6e2adb43ff8f8eede697
>
> good:
> http://www.alsa-project.org/db/?f=11290fe50066e9bcd6a244f2c83b1c66c9dd201b
>
>
> I hope someone can take it from here. I'm not much more than a user. Just
> because i managed to build a kernel doesn't mean i can fix this bug.
>

I think the Mic part might be the same problem I had. I found out that
the following code:

static void via_auto_init_analog_input(struct hda_codec *codec)
{
       struct via_spec *spec = codec->spec;
       const struct auto_pin_cfg *cfg = &spec->autocfg;
       unsigned int ctl;
       int i;

       for (i = 0; i < cfg->num_inputs; i++) {
               hda_nid_t nid = cfg->inputs[i].pin;
               if (spec->smart51_enabled && is_smart51_pins(spec, nid))
                       ctl = PIN_OUT;
               else if (i == AUTO_PIN_MIC)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
                       ctl = PIN_VREF50;
               else
                       ctl = PIN_IN;
               snd_hda_codec_write(codec, nid, 0,
                                   AC_VERB_SET_PIN_WIDGET_CONTROL, ctl);
       }
}

configures correctly only the first MIC (in my case it was Rear MIC).
Front Mic pin was configured as HiZ.
Changing the underlined condition to

else if (cfg->input[i].type == AUTO_PIN_MIC)

resolved the issue for me. (In alsa driver 1.0.23 this code was
different, it checked that i <= FRONT_MIC index).

I'm also just the user of alsa driver, so can't decide whether this is
the proper fix. Maybe someone of knowledgeable developers could check
it.

-- 
Mark Goldstein

Re: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

[Raymond Yau]

2011/2/20 Mark Goldstein <goldstein.mark@gmail.com>

>
> I think the Mic part might be the same problem I had. I found out that
> the following code:
>
> static void via_auto_init_analog_input(struct hda_codec *codec)
> {
>       struct via_spec *spec = codec->spec;
>       const struct auto_pin_cfg *cfg = &spec->autocfg;
>       unsigned int ctl;
>       int i;
>
>       for (i = 0; i < cfg->num_inputs; i++) {
>               hda_nid_t nid = cfg->inputs[i].pin;
>               if (spec->smart51_enabled && is_smart51_pins(spec, nid))
>                       ctl = PIN_OUT;
>               else if (i == AUTO_PIN_MIC)
>                         ^^^^^^^^^^^^^^^^^^^^^^^^^
>                       ctl = PIN_VREF50;
>               else
>                       ctl = PIN_IN;
>               snd_hda_codec_write(codec, nid, 0,
>                                   AC_VERB_SET_PIN_WIDGET_CONTROL, ctl);
>       }
> }
>
> configures correctly only the first MIC (in my case it was Rear MIC).
> Front Mic pin was configured as HiZ.
> Changing the underlined condition to
>
> else if (cfg->input[i].type == AUTO_PIN_MIC)
>
> resolved the issue for me. (In alsa driver 1.0.23 this code was
> different, it checked that i <= FRONT_MIC index).
>

This may fix your vt1708s smart51 since only rear mic and line in are
retasked


static int is_smart51_pins(struct via_spec *spec, hda_nid_t pin)
{
    const struct auto_pin_cfg *cfg = &spec->autocfg;
    int i;
        if (cfg->line_outs != 1)
        return 0;
    for (i = 0; i < cfg->num_inputs; i++) {
        if (pin == cfg->inputs[i].pin) {
                        switch(cfg->inputs[i].type){
            case AUTO_PIN_LINE_IN:
                    return 1;
                        case AUTO_PIN_MIC:
                                if (
strncmp(hda_get_autocfg_input_label(spec->codec,cfg,i),"Rear Mic",8) == 0 )
                           return 1;
                else
                    return 0;
            default:
                return 0;
                        }
                }
    }
    return 0;
}

http://git.alsa-project.org/?p=alsa-kernel.git;a=commit;h=1564b2878f5cf160f60af99d4dbca1dd7809ee8a

Smart 5.1 is for 3-jacks model, to reuse input pins as outputs.
While off, they act as "line out" / "line in" / "mic in".
While on, they acts as "line out" / "back left/right" / "center/lfe".

Re: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

[Mark Goldstein]

On Mon, Feb 21, 2011 at 5:01 AM, Raymond Yau
<superquad.vortex2@gmail.com> wrote:
> 2011/2/20 Mark Goldstein <goldstein.mark@gmail.com>
>
>>
>> I think the Mic part might be the same problem I had. I found out that
>> the following code:
>>
>> static void via_auto_init_analog_input(struct hda_codec *codec)
>> {
>>       struct via_spec *spec = codec->spec;
>>       const struct auto_pin_cfg *cfg = &spec->autocfg;
>>       unsigned int ctl;
>>       int i;
>>
>>       for (i = 0; i < cfg->num_inputs; i++) {
>>               hda_nid_t nid = cfg->inputs[i].pin;
>>               if (spec->smart51_enabled && is_smart51_pins(spec, nid))
>>                       ctl = PIN_OUT;
>>               else if (i == AUTO_PIN_MIC)
>>                         ^^^^^^^^^^^^^^^^^^^^^^^^^
>>                       ctl = PIN_VREF50;
>>               else
>>                       ctl = PIN_IN;
>>               snd_hda_codec_write(codec, nid, 0,
>>                                   AC_VERB_SET_PIN_WIDGET_CONTROL, ctl);
>>       }
>> }
>>
>> configures correctly only the first MIC (in my case it was Rear MIC).
>> Front Mic pin was configured as HiZ.
>> Changing the underlined condition to
>>
>> else if (cfg->input[i].type == AUTO_PIN_MIC)
>>
>> resolved the issue for me. (In alsa driver 1.0.23 this code was
>> different, it checked that i <= FRONT_MIC index).
>>
>
> This may fix your vt1708s smart51 since only rear mic and line in are
> retasked
>
>
> static int is_smart51_pins(struct via_spec *spec, hda_nid_t pin)
> {
>    const struct auto_pin_cfg *cfg = &spec->autocfg;
>    int i;
>        if (cfg->line_outs != 1)
>        return 0;
>    for (i = 0; i < cfg->num_inputs; i++) {
>        if (pin == cfg->inputs[i].pin) {
>                        switch(cfg->inputs[i].type){
>            case AUTO_PIN_LINE_IN:
>                    return 1;
>                        case AUTO_PIN_MIC:
>                                if (
> strncmp(hda_get_autocfg_input_label(spec->codec,cfg,i),"Rear Mic",8) == 0 )
>                           return 1;
>                else
>                    return 0;
>            default:
>                return 0;
>                        }
>                }
>    }
>    return 0;
> }
>
> http://git.alsa-project.org/?p=alsa-kernel.git;a=commit;h=1564b2878f5cf160f60af99d4dbca1dd7809ee8a
>
> Smart 5.1 is for 3-jacks model, to reuse input pins as outputs.
> While off, they act as "line out" / "line in" / "mic in".
> While on, they acts as "line out" / "back left/right" / "center/lfe".

Hi Raymond,
I've always had spart5.1 disabled and still Front Mic PIN has been
configured as High Impedance and did not work until I changed the code
as I described.

What I see in this function (is_smart51_pins) is that pin type is
checked the same way I tried, that is cfg->inputs[i].type is compared
to AUTO_PIN_MIC and not "i" itself as in the code of
via_auto_init_analog_input.

So should the via_auto_init_analog_input be fixed? What do you think?

BTW for some reason I can't see the link included in your mail, I'm
getting: 403 Forbidden - No such project

Thank you & regards,
-- 
Mark Goldstein

Re: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

[Raymond Yau]

2011/2/21 Mark Goldstein <goldstein.mark@gmail.com>

> On Mon, Feb 21, 2011 at 5:01 AM, Raymond Yau
> <superquad.vortex2@gmail.com> wrote:
> > 2011/2/20 Mark Goldstein <goldstein.mark@gmail.com>
> >
> >>
> >> I think the Mic part might be the same problem I had. I found out that
> >> the following code:
> >>
> >> static void via_auto_init_analog_input(struct hda_codec *codec)
> >> {
> >>       struct via_spec *spec = codec->spec;
> >>       const struct auto_pin_cfg *cfg = &spec->autocfg;
> >>       unsigned int ctl;
> >>       int i;
> >>
> >>       for (i = 0; i < cfg->num_inputs; i++) {
> >>               hda_nid_t nid = cfg->inputs[i].pin;
> >>               if (spec->smart51_enabled && is_smart51_pins(spec, nid))
> >>                       ctl = PIN_OUT;
> >>               else if (i == AUTO_PIN_MIC)
> >>                         ^^^^^^^^^^^^^^^^^^^^^^^^^
> >>                       ctl = PIN_VREF50;
> >>               else
> >>                       ctl = PIN_IN;
> >>               snd_hda_codec_write(codec, nid, 0,
> >>                                   AC_VERB_SET_PIN_WIDGET_CONTROL, ctl);
> >>       }
> >> }
> >>
> >> configures correctly only the first MIC (in my case it was Rear MIC).
> >> Front Mic pin was configured as HiZ.
> >> Changing the underlined condition to
> >>
> >> else if (cfg->input[i].type == AUTO_PIN_MIC)
> >>
> >> resolved the issue for me. (In alsa driver 1.0.23 this code was
> >> different, it checked that i <= FRONT_MIC index).
> >>
> >
> > This may fix your vt1708s smart51 since only rear mic and line in are
> > retasked
> >
> >
> > static int is_smart51_pins(struct via_spec *spec, hda_nid_t pin)
> > {
> >    const struct auto_pin_cfg *cfg = &spec->autocfg;
> >    int i;
> >        if (cfg->line_outs != 1)
> >        return 0;
> >    for (i = 0; i < cfg->num_inputs; i++) {
> >        if (pin == cfg->inputs[i].pin) {
> >                        switch(cfg->inputs[i].type){
> >            case AUTO_PIN_LINE_IN:
> >                    return 1;
> >                        case AUTO_PIN_MIC:
> >                                if (
> > strncmp(hda_get_autocfg_input_label(spec->codec,cfg,i),"Rear Mic",8) == 0
> )
> >                           return 1;
> >                else
> >                    return 0;
> >            default:
> >                return 0;
> >                        }
> >                }
> >    }
> >    return 0;
> > }
> >
> >
> http://git.alsa-project.org/?p=alsa-kernel.git;a=commit;h=1564b2878f5cf160f60af99d4dbca1dd7809ee8a
> >
> > Smart 5.1 is for 3-jacks model, to reuse input pins as outputs.
> > While off, they act as "line out" / "line in" / "mic in".
> > While on, they acts as "line out" / "back left/right" / "center/lfe".
>
> Hi Raymond,
> I've always had spart5.1 disabled and still Front Mic PIN has been
> configured as High Impedance and did not work until I changed the code
> as I described.
>
> What I see in this function (is_smart51_pins) is that pin type is
> checked the same way I tried, that is cfg->inputs[i].type is compared
> to AUTO_PIN_MIC and not "i" itself as in the code of
> via_auto_init_analog_input.
>
> So should the via_auto_init_analog_input be fixed? What do you think?
>
> BTW for some reason I can't see the link included in your mail, I'm
> getting: 403 Forbidden - No such project
>
> Thank you & regards,
> --
> Mark Goldstein
>

author    Lydia Wang <lydiawang@viatech.com.cn>
Sat, 10 Oct 2009 11:07:52 +0000 (19:07 +0800)
committer    Takashi Iwai <tiwai@suse.de>
     Sun, 11 Oct 2009 15:56:53 +0000 (17:56 +0200)
commit    1564b2878f5cf160f60af99d4dbca1dd7809ee8a
tree    2224b34919c247b6bfacce32a81a0953036fc0c4
parent    cdc1784d49258198df600fbc1d37c07d7eee5ed6


http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=1564b2878f5cf160f60af99d4dbca1dd7809ee8a;hp=cdc1784d49258198df600fbc1d37c07d7eee5ed6

in the patch , just only front mic

+               if (i == AUTO_PIN_FRONT_MIC) {
+                       if (spec->codec_type == VT1708S) {
+                               /* input = index 1 (AOW3) */
+                               snd_hda_codec_write(
+                                       codec, nid, 0,
+                                       AC_VERB_SET_CONNECT_SEL, 1);
+                               snd_hda_codec_amp_stereo(
+                                       codec, nid, HDA_OUTPUT,
+                                       0, HDA_AMP_MUTE, HDA_AMP_UNMUTE);
+                       }
+               }

but now become any mic

1406                 if (cfg->inputs[i].type == AUTO_PIN_MIC) {
1407                         if (spec->codec_type == VT1708S
1408                             || spec->codec_type == VT1716S) {
1409                                 /* input = index 1 (AOW3) */
1410                                 snd_hda_codec_write(
1411                                         codec, nid, 0,
1412                                         AC_VERB_SET_CONNECT_SEL, 1);
1413                                 snd_hda_codec_amp_stereo(
1414                                         codec, nid, HDA_OUTPUT,
1415                                         0, HDA_AMP_MUTE,
HDA_AMP_UNMUTE);
1416                         }
1417                 }
1418         }

Re: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

[David Henningsson]

On 2011-02-20 12:06, Mark Goldstein wrote:
> I think the Mic part might be the same problem I had. I found out that
> the following code:
>
> static void via_auto_init_analog_input(struct hda_codec *codec)
> {
>         struct via_spec *spec = codec->spec;
>         const struct auto_pin_cfg *cfg =&spec->autocfg;
>         unsigned int ctl;
>         int i;
>
>         for (i = 0; i<  cfg->num_inputs; i++) {
>                 hda_nid_t nid = cfg->inputs[i].pin;
>                 if (spec->smart51_enabled&&  is_smart51_pins(spec, nid))
>                         ctl = PIN_OUT;
>                 else if (i == AUTO_PIN_MIC)
>                           ^^^^^^^^^^^^^^^^^^^^^^^^^
>                         ctl = PIN_VREF50;
>                 else
>                         ctl = PIN_IN;
>                 snd_hda_codec_write(codec, nid, 0,
>                                     AC_VERB_SET_PIN_WIDGET_CONTROL, ctl);
>         }
> }
>
> configures correctly only the first MIC (in my case it was Rear MIC).
> Front Mic pin was configured as HiZ.
> Changing the underlined condition to
>
> else if (cfg->input[i].type == AUTO_PIN_MIC)
>
> resolved the issue for me. (In alsa driver 1.0.23 this code was
> different, it checked that i<= FRONT_MIC index).
>
> I'm also just the user of alsa driver, so can't decide whether this is
> the proper fix. Maybe someone of knowledgeable developers could check
> it.

It looks like the proper fix to me. If you like the fame and fortune ;-) 
of having a commits in the kernel, I encourage you to submit a patch. 
Remember to have proper "Cc: stable@kernel.org" and "Signed-off-by" 
lines in the the patch header, and to cc Takashi on the resulting email.

If not, I'll be happy to do it for you. It seems like an important fix 
to me.

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

Re: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

[Mark Goldstein]

On Mon, Feb 21, 2011 at 10:35 AM, David Henningsson
<david.henningsson@canonical.com> wrote:
> On 2011-02-20 12:06, Mark Goldstein wrote:
>>
>> I think the Mic part might be the same problem I had. I found out that
>> the following code:
>>
>> static void via_auto_init_analog_input(struct hda_codec *codec)
>> {
>>        struct via_spec *spec = codec->spec;
>>        const struct auto_pin_cfg *cfg =&spec->autocfg;
>>        unsigned int ctl;
>>        int i;
>>
>>        for (i = 0; i<  cfg->num_inputs; i++) {
>>                hda_nid_t nid = cfg->inputs[i].pin;
>>                if (spec->smart51_enabled&&  is_smart51_pins(spec, nid))
>>                        ctl = PIN_OUT;
>>                else if (i == AUTO_PIN_MIC)
>>                          ^^^^^^^^^^^^^^^^^^^^^^^^^
>>                        ctl = PIN_VREF50;
>>                else
>>                        ctl = PIN_IN;
>>                snd_hda_codec_write(codec, nid, 0,
>>                                    AC_VERB_SET_PIN_WIDGET_CONTROL, ctl);
>>        }
>> }
>>
>> configures correctly only the first MIC (in my case it was Rear MIC).
>> Front Mic pin was configured as HiZ.
>> Changing the underlined condition to
>>
>> else if (cfg->input[i].type == AUTO_PIN_MIC)
>>
>> resolved the issue for me. (In alsa driver 1.0.23 this code was
>> different, it checked that i<= FRONT_MIC index).
>>
>> I'm also just the user of alsa driver, so can't decide whether this is
>> the proper fix. Maybe someone of knowledgeable developers could check
>> it.
>
> It looks like the proper fix to me. If you like the fame and fortune ;-) of
> having a commits in the kernel, I encourage you to submit a patch. Remember
> to have proper "Cc: stable@kernel.org" and "Signed-off-by" lines in the the
> patch header, and to cc Takashi on the resulting email.
>
> If not, I'll be happy to do it for you. It seems like an important fix to
> me.
>
> --
> David Henningsson, Canonical Ltd.
> http://launchpad.net/~diwic
>

David,

I've never dealt with submitting patches, so probably it'll be better
(and definitely faster) if you could do it.

Thank you,
-- 
Mark Goldstein

[PATCH] ALSA: HDA: Fix mic initialization in VIA auto parser (was: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected))

[David Henningsson]

[-- Attachment #1: Type: text/plain, Size: 2337 bytes --]

On 2011-02-21 09:43, Mark Goldstein wrote:
> On Mon, Feb 21, 2011 at 10:35 AM, David Henningsson
> <david.henningsson@canonical.com>  wrote:
>> On 2011-02-20 12:06, Mark Goldstein wrote:
>>>
>>> I think the Mic part might be the same problem I had. I found out that
>>> the following code:
>>>
>>> static void via_auto_init_analog_input(struct hda_codec *codec)
>>> {
>>>         struct via_spec *spec = codec->spec;
>>>         const struct auto_pin_cfg *cfg =&spec->autocfg;
>>>         unsigned int ctl;
>>>         int i;
>>>
>>>         for (i = 0; i<    cfg->num_inputs; i++) {
>>>                 hda_nid_t nid = cfg->inputs[i].pin;
>>>                 if (spec->smart51_enabled&&    is_smart51_pins(spec, nid))
>>>                         ctl = PIN_OUT;
>>>                 else if (i == AUTO_PIN_MIC)
>>>                           ^^^^^^^^^^^^^^^^^^^^^^^^^
>>>                         ctl = PIN_VREF50;
>>>                 else
>>>                         ctl = PIN_IN;
>>>                 snd_hda_codec_write(codec, nid, 0,
>>>                                     AC_VERB_SET_PIN_WIDGET_CONTROL, ctl);
>>>         }
>>> }
>>>
>>> configures correctly only the first MIC (in my case it was Rear MIC).
>>> Front Mic pin was configured as HiZ.
>>> Changing the underlined condition to
>>>
>>> else if (cfg->input[i].type == AUTO_PIN_MIC)
>>>
>>> resolved the issue for me. (In alsa driver 1.0.23 this code was
>>> different, it checked that i<= FRONT_MIC index).
>>>
>>> I'm also just the user of alsa driver, so can't decide whether this is
>>> the proper fix. Maybe someone of knowledgeable developers could check
>>> it.
>>
>> It looks like the proper fix to me. If you like the fame and fortune ;-) of
>> having a commits in the kernel, I encourage you to submit a patch. Remember
>> to have proper "Cc: stable@kernel.org" and "Signed-off-by" lines in the the
>> patch header, and to cc Takashi on the resulting email.
>>
>> If not, I'll be happy to do it for you. It seems like an important fix to
>> me.
>>
>> --
>> David Henningsson, Canonical Ltd.
>> http://launchpad.net/~diwic
>>
>
> David,
>
> I've never dealt with submitting patches, so probably it'll be better
> (and definitely faster) if you could do it.
>
> Thank you,

Ok, here comes the patch!

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

[-- Attachment #2: 0001-ALSA-HDA-Fix-mic-initialization-in-VIA-auto-parser.patch --]
[-- Type: text/x-patch, Size: 1065 bytes --]

>From a28dd20815b47134bc342a6ec9b9da6e80f59837 Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Mon, 21 Feb 2011 10:23:18 +0100
Subject: [PATCH] ALSA: HDA: Fix mic initialization in VIA auto parser

This typo caused some microphone inputs not to be correctly
initialized on VIA codecs.

Reported-By: Mark Goldstein <goldstein.mark@gmail.com>
Cc: stable@kernel.org
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/patch_via.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index a76c326..63b0054 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -567,7 +567,7 @@ static void via_auto_init_analog_input(struct hda_codec *codec)
 		hda_nid_t nid = cfg->inputs[i].pin;
 		if (spec->smart51_enabled && is_smart51_pins(spec, nid))
 			ctl = PIN_OUT;
-		else if (i == AUTO_PIN_MIC)
+		else if (cfg->inputs[i].type == AUTO_PIN_MIC)
 			ctl = PIN_VREF50;
 		else
 			ctl = PIN_IN;
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ALSA: HDA: Fix mic initialization in VIA auto parser (was: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected))

[Wolfgang Scheicher]

David Henningsson wrote:

> On 2011-02-21 09:43, Mark Goldstein wrote:
>> [...]
>>
>> I've never dealt with submitting patches, so probably it'll be better
>> (and definitely faster) if you could do it.
>>
>> Thank you,
> 
> Ok, here comes the patch!

Tested, and Microphone now works! Thanks a lot to everyone involved.
Good job so far!

On a side note:
One still must not touch "Smart 5.1" in alsamixer, because if one does, 
mixer will still crash and (sound)system will hang until pc is rebooted.
I can't tell how related this two problems are, but as far as i can tell 
they both appeared with the same commit
( 7b315bb4980448250c80a7464c256b54d546cb26 ) i did track down on sunday.

Wolfgang Scheicher

Re: [PATCH] ALSA: HDA: Fix mic initialization in VIA auto parser (was: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected))

[Raymond Yau]

2011/2/22 Wolfgang Scheicher <wolfgang.scheicher@gmail.com>

> David Henningsson wrote:
>
> > On 2011-02-21 09:43, Mark Goldstein wrote:
> >> [...]
> >>
> >> I've never dealt with submitting patches, so probably it'll be better
> >> (and definitely faster) if you could do it.
> >>
> >> Thank you,
> >
> > Ok, here comes the patch!
>
> Tested, and Microphone now works! Thanks a lot to everyone involved.
> Good job so far!
>
> On a side note:
> One still must not touch "Smart 5.1" in alsamixer, because if one does,
> mixer will still crash and (sound)system will hang until pc is rebooted.
> I can't tell how related this two problems are, but as far as i can tell
> they both appeared with the same commit
> ( 7b315bb4980448250c80a7464c256b54d546cb26 ) i did track down on sunday.
>
> Wolfgang Scheicher
>

This will disable the creation of smart51 switch for those non 3-jacks model

static int via_smart51_build(struct via_spec *spec)
{
    struct snd_kcontrol_new *knew;
    const struct auto_pin_cfg *cfg = &spec->autocfg;
    hda_nid_t nid;
    int i;
+        if (spec->autocfg.line_outs != 1) {
+        spec->smart51_enabled=0;
+       return 0;
+     }

Re: [PATCH] ALSA: HDA: Fix mic initialization in VIA auto parser (was: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected))

[Wolfgang Scheicher]

Wolfgang Scheicher wrote:

> David Henningsson wrote:
> 
>> On 2011-02-21 09:43, Mark Goldstein wrote:
>>> [...]
>>>
>>> I've never dealt with submitting patches, so probably it'll be better
>>> (and definitely faster) if you could do it.
>>>
>>> Thank you,
>> 
>> Ok, here comes the patch!
> 
> Tested, and Microphone now works! Thanks a lot to everyone involved.
> Good job so far!

Hmm ... Just tried kernel 2.6.38 from debian sid, and Microphone is not 
working again. However, this fix is in.
What might have broken it this time?
I hope to find some time to track down the commit somewhen the next days ...

Wolfgang Scheicher

Re: [PATCH] ALSA: HDA: Fix mic initialization in VIA auto parser (was: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected))

[Mark Goldstein]

On Wed, Mar 23, 2011 at 12:41 PM, Wolfgang Scheicher
<wolfgang.scheicher@gmail.com> wrote:
> Wolfgang Scheicher wrote:
>
>> David Henningsson wrote:
>>
>>> On 2011-02-21 09:43, Mark Goldstein wrote:
>>>> [...]
>>>>
>>>> I've never dealt with submitting patches, so probably it'll be better
>>>> (and definitely faster) if you could do it.
>>>>
>>>> Thank you,
>>>
>>> Ok, here comes the patch!
>>
>> Tested, and Microphone now works! Thanks a lot to everyone involved.
>> Good job so far!
>
> Hmm ... Just tried kernel 2.6.38 from debian sid, and Microphone is not
> working again. However, this fix is in.
> What might have broken it this time?
> I hope to find some time to track down the commit somewhen the next days ...
>

Wolfgang,

When I was fighting with Mic issue, I used hda-analyser script. Try it
and check how the pin 0x1e (Front Mic) is configured.
My symptom was that this pin has been initiated with VREF Hi-Z.
If you see that, try changing it to VREF 50. Mic should start working.

Regards,
-- 
Mark Goldstein

Re: [PATCH] ALSA: HDA: Fix mic initialization in VIA auto parser (was: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected))

[Wolfgang Scheicher]

Mark Goldstein wrote:

> On Wed, Mar 23, 2011 at 12:41 PM, Wolfgang Scheicher
>> Hmm ... Just tried kernel 2.6.38 from debian sid, and Microphone is not
>> working again. However, this fix is in.
>> What might have broken it this time?
>> I hope to find some time to track down the commit somewhen the next days
>> ...
> 
> Wolfgang,
> 
> When I was fighting with Mic issue, I used hda-analyser script. Try it
> and check how the pin 0x1e (Front Mic) is configured.
> My symptom was that this pin has been initiated with VREF Hi-Z.
> If you see that, try changing it to VREF 50. Mic should start working.

Oh - didn't know that. Impressive Script.

And just found out this time it was was propably false alarm.

All that happened is that both input sources got set to front mic when 
booting this kernel, and after selecting the correct (rear) source in the 
mixer things work.

Wolfgang Scheicher

Re: [PATCH] ALSA: HDA: Fix mic initialization in VIA auto parser (was: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected))

[Takashi Iwai]

At Mon, 21 Feb 2011 10:29:50 +0100,
David Henningsson wrote:
> 
> On 2011-02-21 09:43, Mark Goldstein wrote:
> > On Mon, Feb 21, 2011 at 10:35 AM, David Henningsson
> > <david.henningsson@canonical.com>  wrote:
> >> On 2011-02-20 12:06, Mark Goldstein wrote:
> >>>
> >>> I think the Mic part might be the same problem I had. I found out that
> >>> the following code:
> >>>
> >>> static void via_auto_init_analog_input(struct hda_codec *codec)
> >>> {
> >>>         struct via_spec *spec = codec->spec;
> >>>         const struct auto_pin_cfg *cfg =&spec->autocfg;
> >>>         unsigned int ctl;
> >>>         int i;
> >>>
> >>>         for (i = 0; i<    cfg->num_inputs; i++) {
> >>>                 hda_nid_t nid = cfg->inputs[i].pin;
> >>>                 if (spec->smart51_enabled&&    is_smart51_pins(spec, nid))
> >>>                         ctl = PIN_OUT;
> >>>                 else if (i == AUTO_PIN_MIC)
> >>>                           ^^^^^^^^^^^^^^^^^^^^^^^^^
> >>>                         ctl = PIN_VREF50;
> >>>                 else
> >>>                         ctl = PIN_IN;
> >>>                 snd_hda_codec_write(codec, nid, 0,
> >>>                                     AC_VERB_SET_PIN_WIDGET_CONTROL, ctl);
> >>>         }
> >>> }
> >>>
> >>> configures correctly only the first MIC (in my case it was Rear MIC).
> >>> Front Mic pin was configured as HiZ.
> >>> Changing the underlined condition to
> >>>
> >>> else if (cfg->input[i].type == AUTO_PIN_MIC)
> >>>
> >>> resolved the issue for me. (In alsa driver 1.0.23 this code was
> >>> different, it checked that i<= FRONT_MIC index).
> >>>
> >>> I'm also just the user of alsa driver, so can't decide whether this is
> >>> the proper fix. Maybe someone of knowledgeable developers could check
> >>> it.
> >>
> >> It looks like the proper fix to me. If you like the fame and fortune ;-) of
> >> having a commits in the kernel, I encourage you to submit a patch. Remember
> >> to have proper "Cc: stable@kernel.org" and "Signed-off-by" lines in the the
> >> patch header, and to cc Takashi on the resulting email.
> >>
> >> If not, I'll be happy to do it for you. It seems like an important fix to
> >> me.
> >>
> >> --
> >> David Henningsson, Canonical Ltd.
> >> http://launchpad.net/~diwic
> >>
> >
> > David,
> >
> > I've never dealt with submitting patches, so probably it'll be better
> > (and definitely faster) if you could do it.
> >
> > Thank you,
> 
> Ok, here comes the patch!

Applied it now.  Thanks!


Takashi

> 
> -- 
> David Henningsson, Canonical Ltd.
> http://launchpad.net/~diwic
> [2 0001-ALSA-HDA-Fix-mic-initialization-in-VIA-auto-parser.patch <text/x-patch (7bit)>]
> >From a28dd20815b47134bc342a6ec9b9da6e80f59837 Mon Sep 17 00:00:00 2001
> From: David Henningsson <david.henningsson@canonical.com>
> Date: Mon, 21 Feb 2011 10:23:18 +0100
> Subject: [PATCH] ALSA: HDA: Fix mic initialization in VIA auto parser
> 
> This typo caused some microphone inputs not to be correctly
> initialized on VIA codecs.
> 
> Reported-By: Mark Goldstein <goldstein.mark@gmail.com>
> Cc: stable@kernel.org
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
>  sound/pci/hda/patch_via.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> index a76c326..63b0054 100644
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -567,7 +567,7 @@ static void via_auto_init_analog_input(struct hda_codec *codec)
>  		hda_nid_t nid = cfg->inputs[i].pin;
>  		if (spec->smart51_enabled && is_smart51_pins(spec, nid))
>  			ctl = PIN_OUT;
> -		else if (i == AUTO_PIN_MIC)
> +		else if (cfg->inputs[i].type == AUTO_PIN_MIC)
>  			ctl = PIN_VREF50;
>  		else
>  			ctl = PIN_IN;
> -- 
> 1.7.1
> 

Re: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

[Raymond Yau]

2011/2/20 Wolfgang Scheicher <wolfgang.scheicher@gmail.com>

> On Sunday 20 February 2011 14:27:52 you wrote:
> > 2011/2/20 Wolfgang Scheicher <wolfgang.scheicher@gmail.com>
> >
> >> After the mentioned Kernel upgrade quite a view things went wrong on my
> >> hardware ( http://www.asrock.com/mb/overview.asp?Model=890GM%20Pro3 ):
> >>
> >> * Microphone doesn't work anymore. neither the front mic nor the rear
> >> one. Tried all thinkable settings.
> >>
> >> * Increasing Microphone levels leads to some strange internal feedback.
> >> That
> >> means, at some point when the feedback starts, it just starts, but i
> have
> >> no
> >> clue what audio source did actually trigger it.
> >>
> >> * Touching the mixer channel "Smart 5.1" in alsamixer makes alsamicer
> >> crash.
> >
> > Refer to the user manual , the motherboard has 5 audio jacks in rear
> panel,
> >
> > 7.1 need retasking of Line in (blue jacks) as side
> >
> > Audio Output Channels Front Speaker Rear Speaker Central / Bass Line In
> >                         (No. 9)       (No. 6)      (No. 5)     (No. 8)
> >         2                  V             --           --          --
> >         4                  V             V            --          --
> >         6                  V             V            V           --
> >         8                  V             V            V           V
>
> Forgive me, but i don't understand.
> I hope this doesn't mean i have to solder on my Mainboard if i intend to
> use a
> newer kernel.
>
> If there is something i can do, please explain in more detail.
>
> --
> Worf
>


http://git.alsa-project.org/?p=alsa-kernel.git;a=commit;h=1564b2878f5cf160f60af99d4dbca1dd7809ee8a

Smart 5.1 is for 3-jacks model, to reuse input pins as outputs.
While off, they act as "line out" / "line in" / "mic in".
While on, they acts as "line out" / "back left/right" / "center/lfe".

If the driver use "Smart5.1 switch" for those 5-jacks model, you will need
to modify the function is_smart51_pins()


static int is_smart51_pins(struct via_spec *spec, hda_nid_t pin)
{
	const struct auto_pin_cfg *cfg = &spec->autocfg;
	int i;
        if (cfg->line_outs == 4)
            return 0;
	for (i = 0; i < cfg->num_inputs; i++) {
		if (pin == cfg->inputs[i].pin) {
                        switch(cfg->inputs[i].type){
			case AUTO_PIN_LINE_IN:
			        return (cfg->line_outs == 3 || cfg->line_outs == 1);
                        case AUTO_PIN_MIC:
                                if (
strncmp(hda_get_autocfg_input_label(spec->codec,cfg,i),"Rear Mic",8)
== 0 )
			           return (cfg->line_outs == 1);
                        }
                }
	}
	return 0;
}

Re: pci/hda/patch_via.c - broken between 2.6.36 and 2.6.37 (bisected)

[Raymond Yau]

2011/2/20 Wolfgang Scheicher <wolfgang.scheicher@gmail.com>

> On Sunday 20 February 2011 14:27:52 you wrote:
> > 2011/2/20 Wolfgang Scheicher <wolfgang.scheicher@gmail.com>
> >
> >> After the mentioned Kernel upgrade quite a view things went wrong on my
> >> hardware ( http://www.asrock.com/mb/overview.asp?Model=890GM%20Pro3 ):
> >>
> >> * Microphone doesn't work anymore. neither the front mic nor the rear
> >> one. Tried all thinkable settings.
> >>
> >> * Increasing Microphone levels leads to some strange internal feedback.
> >> That
> >> means, at some point when the feedback starts, it just starts, but i
> have
> >> no
> >> clue what audio source did actually trigger it.
> >>
> >> * Touching the mixer channel "Smart 5.1" in alsamixer makes alsamicer
> >> crash.
> >
> > Refer to the user manual , the motherboard has 5 audio jacks in rear
> panel,
> >
> > 7.1 need retasking of Line in (blue jacks) as side
> >
> > Audio Output Channels Front Speaker Rear Speaker Central / Bass Line In
> >                         (No. 9)       (No. 6)      (No. 5)     (No. 8)
> >         2                  V             --           --          --
> >         4                  V             V            --          --
> >         6                  V             V            V           --
> >         8                  V             V            V           V
>
> Forgive me, but i don't understand.
> I hope this doesn't mean i have to solder on my Mainboard if i intend to
> use a
> newer kernel.
>
> If there is something i can do, please explain in more detail.
>
> --
> Worf
>

A better way is to disable the creation of smart5.1 switch when
(cfg->line-outs != 1 ) and use "surround71 switch" to retask "line in" to
side