From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Remove module probe announcements from CODEC drivers
Date: Tue, 1 Mar 2011 14:17:09 -0600 [thread overview]
Message-ID: <4D6D5445.3010202@freescale.com> (raw)
In-Reply-To: <1299010455-31934-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Mark Brown wrote:
> static int __init cs4270_init(void)
> {
> - pr_info("Cirrus Logic CS4270 ALSA SoC Codec Driver\n");
> -
> return i2c_add_driver(&cs4270_i2c_driver);
> }
I'm not fond of this at all.
Can I get a justification for this change? On my boards, the CS4270 driver is
compiled in-kernel, not as a module, and so when the kernel boots, the driver
announces itself when it's loaded. I like this a lot, which is why I always put
a pr_info() in the __init function of my modules.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-03-01 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 20:14 [PATCH] ASoC: Remove module probe announcements from CODEC drivers Mark Brown
2011-03-01 20:17 ` Timur Tabi [this message]
2011-03-01 20:21 ` Mark Brown
2011-03-01 20:57 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6D5445.3010202@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).