alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Raymond Yau <superquad.vortex2@gmail.com>
Cc: Maarten Lankhorst <m.b.lankhorst@gmail.com>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] Alsa-plugins: Pulse: Fix snd_pcm_avail returning 0 in some cases
Date: Tue, 26 Apr 2011 10:01:23 +0200	[thread overview]
Message-ID: <4DB67BD3.7090706@canonical.com> (raw)
In-Reply-To: <BANLkTikb0uuEw9-gbbGW6Kcf0LkPHsgxdw@mail.gmail.com>

On 2011-04-22 01:25, Raymond Yau wrote:
> 2011/4/21 David Henningsson<david.henningsson@canonical.com>
>
>> Due to a round-off error, snd_pcm_avail could in some cases
>> return 0 even though more data could be written to the stream.
>>
>> This was discovered by Maarten Lankhorst [1], and there is also a test
>> program available that triggers this error [2].
>>
>> [1]
>> https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-April/009935.html
>>
>> [2]
>> https://tango.0pointer.de/pipermail/pulseaudio-discuss/attachments/20110420/3c852d6e/attachment.c
>>
>
> if the test program can force under-run occur with "hw" device and "pulse"
> device with his patch in
> https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-April/009918.html
>
> Is it normal that underrun does not occur with the test program and your
> patch

Yes; underruns are not reported to the application due to the risk of 
the underrun being obsolete at that time. As for Maarten's patch in the 
post you refer to,

1) if underruns are being reported (this is configurable), it might be a 
good idea to call "pulse_start".

2) it changes underruns to being reported by default, which is what I'm 
opposed to.

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

  reply	other threads:[~2011-04-26  8:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 13:22 [PATCH] Alsa-plugins: Pulse: Fix snd_pcm_avail returning 0 in some cases David Henningsson
2011-04-21 23:25 ` Raymond Yau
2011-04-26  8:01   ` David Henningsson [this message]
2011-04-26 14:39     ` Takashi Iwai
2011-05-07  3:18       ` Raymond Yau
2011-04-27  1:00     ` Raymond Yau
2011-04-29  2:32     ` Raymond Yau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB67BD3.7090706@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=m.b.lankhorst@gmail.com \
    --cc=superquad.vortex2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).