alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Subhasish Ghosh <subhasish@mistralsolutions.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	"Nori, Sekhar" <nsekhar@ti.com>,
	"davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	Troy Kisky <troy.kisky@boundarydevices.com>
Subject: Re: [PATCH 0/2] ASoC: davinci: ping-pong buffers for mcasp on da850evm
Date: Thu, 19 May 2011 12:08:09 +0100	[thread overview]
Message-ID: <4DD4FA19.70107@ti.com> (raw)
In-Reply-To: <cover.1305723716.git.bengardiner@nanometrics.ca>

On 18/05/11 14:27, Ben Gardiner wrote:
> davinci-i2s enables the use of ping-pong buffers by copying the sram sizes
> specified by platform data into the dma params used by davinci-pcm.
> 
> This patch series first implements that same behaviour in davinic-mcasp
> and then specified sram sizes and eventq's for da850evm.
> 
> To achieve the use of ping-pong buffers at runtime this patch depends also
> on the conversion of da850's SRAM allocator to the "Share RAM" region from 
> the "ARM Local RAM" region -- originally proposed by Subhasish Ghosh[1] and
> recently reposted by myself [2].
> 
> This is because the "ARM Local RAM" region currently used by the da850 SRAM
> allocator is not addressable by the EDMA. The resulting behaviour, when
> ping-pong buffers are used by davinci-pcm, is that playback produces silence
> and capture acquires silence.
> 
> However, there is no change in behaviour for da850evm build with the in-tree
> defconfig since suspend allocates SRAM which prevents a successful allocation
> of 8K by davinci-pcm and thus the behaviour falls back to the usual scheme.
> 
> In the case of da850evm builds where CONFIG_SUSPEND is not set, playback 
> will produce silence and capture will acquire silence until such time as the
> patches to change the da850 SRAM allocator to the "Shared RAM" region are 
> merged.
> 
> [1] http://article.gmane.org/gmane.linux.kernel/1098928
> [2] http://article.gmane.org/gmane.linux.ports.arm.kernel/117261
> 
> Ben Gardiner (2):
>   ASoC: davinci-mcasp: enable ping-pong SRAM buffers
>   davinci: da850evm: enable mcasp ping-pong buffers and eventq's
> 
>  arch/arm/mach-davinci/board-da850-evm.c |    5 ++++-
>  sound/soc/davinci/davinci-mcasp.c       |    2 ++
>  2 files changed, 6 insertions(+), 1 deletions(-)
> 

Both

Acked-by: Liam Girdwood <lrg@ti.com>

      parent reply	other threads:[~2011-05-19 11:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 13:27 [PATCH 0/2] ASoC: davinci: ping-pong buffers for mcasp on da850evm Ben Gardiner
2011-05-18 13:27 ` [PATCH 1/2] ASoC: davinci-mcasp: enable ping-pong SRAM buffers Ben Gardiner
2011-05-19 21:13   ` Mark Brown
2011-05-18 13:27 ` [PATCH 2/2] davinci: da850evm: enable mcasp ping-pong bufs and evq's Ben Gardiner
2011-05-19 21:14   ` Mark Brown
     [not found]     ` <20110519211406.GE18849-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-05-20  7:08       ` Nori, Sekhar
2011-05-20  9:05         ` Liam Girdwood
2011-05-19 11:08 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD4FA19.70107@ti.com \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bengardiner@nanometrics.ca \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=nsekhar@ti.com \
    --cc=subhasish@mistralsolutions.com \
    --cc=troy.kisky@boundarydevices.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).