* [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver
@ 2011-05-25 7:53 Daniel Mack
2011-05-25 9:55 ` Liam Girdwood
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Daniel Mack @ 2011-05-25 7:53 UTC (permalink / raw)
To: alsa-devel; +Cc: Liam Girdwood, Mark Brown, Daniel Mack
The comment does not reflect reality anymore since the multi-component
monster patch landed. Things are matched by names now, and not by
exporting and referencing a struct. Fix it to avoid confusion.
Signed-off-by: Daniel Mack <zonque@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>
---
sound/soc/codecs/cs4270.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
index 0206a17..6cc8678 100644
--- a/sound/soc/codecs/cs4270.c
+++ b/sound/soc/codecs/cs4270.c
@@ -636,10 +636,7 @@ static int cs4270_soc_resume(struct snd_soc_codec *codec)
#endif /* CONFIG_PM */
/*
- * ASoC codec device structure
- *
- * Assign this variable to the codec_dev field of the machine driver's
- * snd_soc_device structure.
+ * ASoC codec driver structure
*/
static const struct snd_soc_codec_driver soc_codec_device_cs4270 = {
.probe = cs4270_probe,
--
1.7.5.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver
2011-05-25 7:53 [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver Daniel Mack
@ 2011-05-25 9:55 ` Liam Girdwood
2011-05-25 11:12 ` Mark Brown
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2011-05-25 9:55 UTC (permalink / raw)
To: Daniel Mack; +Cc: alsa-devel@alsa-project.org, Mark Brown, Liam Girdwood
On 25/05/11 08:53, Daniel Mack wrote:
> The comment does not reflect reality anymore since the multi-component
> monster patch landed. Things are matched by names now, and not by
> exporting and referencing a struct. Fix it to avoid confusion.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> ---
> sound/soc/codecs/cs4270.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver
2011-05-25 7:53 [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver Daniel Mack
2011-05-25 9:55 ` Liam Girdwood
@ 2011-05-25 11:12 ` Mark Brown
2011-05-25 18:51 ` Tabi Timur-B04825
2011-05-26 1:27 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2011-05-25 11:12 UTC (permalink / raw)
To: Daniel Mack, timur; +Cc: alsa-devel, Liam Girdwood
On Wed, May 25, 2011 at 09:53:12AM +0200, Daniel Mack wrote:
> The comment does not reflect reality anymore since the multi-component
> monster patch landed. Things are matched by names now, and not by
> exporting and referencing a struct. Fix it to avoid confusion.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
CCing in Timur for his review.
> ---
> sound/soc/codecs/cs4270.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
> index 0206a17..6cc8678 100644
> --- a/sound/soc/codecs/cs4270.c
> +++ b/sound/soc/codecs/cs4270.c
> @@ -636,10 +636,7 @@ static int cs4270_soc_resume(struct snd_soc_codec *codec)
> #endif /* CONFIG_PM */
>
> /*
> - * ASoC codec device structure
> - *
> - * Assign this variable to the codec_dev field of the machine driver's
> - * snd_soc_device structure.
> + * ASoC codec driver structure
> */
> static const struct snd_soc_codec_driver soc_codec_device_cs4270 = {
> .probe = cs4270_probe,
> --
> 1.7.5.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver
2011-05-25 7:53 [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver Daniel Mack
2011-05-25 9:55 ` Liam Girdwood
2011-05-25 11:12 ` Mark Brown
@ 2011-05-25 18:51 ` Tabi Timur-B04825
2011-05-26 1:27 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Tabi Timur-B04825 @ 2011-05-25 18:51 UTC (permalink / raw)
To: Daniel Mack; +Cc: alsa-devel@alsa-project.org, Mark Brown, Liam Girdwood
On Wed, May 25, 2011 at 2:53 AM, Daniel Mack <zonque@gmail.com> wrote:
> The comment does not reflect reality anymore since the multi-component
> monster patch landed. Things are matched by names now, and not by
> exporting and referencing a struct. Fix it to avoid confusion.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
Acked-by: Timur Tabi <timur@freescale.com>
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver
2011-05-25 7:53 [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver Daniel Mack
` (2 preceding siblings ...)
2011-05-25 18:51 ` Tabi Timur-B04825
@ 2011-05-26 1:27 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2011-05-26 1:27 UTC (permalink / raw)
To: Daniel Mack; +Cc: alsa-devel, Liam Girdwood
On Wed, May 25, 2011 at 09:53:12AM +0200, Daniel Mack wrote:
> The comment does not reflect reality anymore since the multi-component
> monster patch landed. Things are matched by names now, and not by
> exporting and referencing a struct. Fix it to avoid confusion.
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-26 1:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-25 7:53 [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver Daniel Mack
2011-05-25 9:55 ` Liam Girdwood
2011-05-25 11:12 ` Mark Brown
2011-05-25 18:51 ` Tabi Timur-B04825
2011-05-26 1:27 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).