* [PATCH] ASoC: wm1250-ev1: Define "WM1250 Output" with SND_SOC_DAPM_OUTPUT
@ 2011-05-26 2:54 Axel Lin
2011-05-26 11:04 ` Liam Girdwood
2011-05-26 14:18 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-05-26 2:54 UTC (permalink / raw)
To: linux-kernel; +Cc: Mark Brown, Liam Girdwood, alsa-devel
Codec output pin should be defined with SND_SOC_DAPM_OUTPUT.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
Note:
Just found this bug while reading the code.
I don't have this hardware handy. I appreciate if someone can test it.
Axel
sound/soc/codecs/wm1250-ev1.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm1250-ev1.c b/sound/soc/codecs/wm1250-ev1.c
index 14d0716..bcc2089 100644
--- a/sound/soc/codecs/wm1250-ev1.c
+++ b/sound/soc/codecs/wm1250-ev1.c
@@ -22,7 +22,7 @@ SND_SOC_DAPM_ADC("ADC", "wm1250-ev1 Capture", SND_SOC_NOPM, 0, 0),
SND_SOC_DAPM_DAC("DAC", "wm1250-ev1 Playback", SND_SOC_NOPM, 0, 0),
SND_SOC_DAPM_INPUT("WM1250 Input"),
-SND_SOC_DAPM_INPUT("WM1250 Output"),
+SND_SOC_DAPM_OUTPUT("WM1250 Output"),
};
static const struct snd_soc_dapm_route wm1250_ev1_dapm_routes[] = {
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: wm1250-ev1: Define "WM1250 Output" with SND_SOC_DAPM_OUTPUT
2011-05-26 2:54 [PATCH] ASoC: wm1250-ev1: Define "WM1250 Output" with SND_SOC_DAPM_OUTPUT Axel Lin
@ 2011-05-26 11:04 ` Liam Girdwood
2011-05-26 14:18 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-05-26 11:04 UTC (permalink / raw)
To: Axel Lin
Cc: alsa-devel@alsa-project.org, Mark Brown,
linux-kernel@vger.kernel.org
On 26/05/11 03:54, Axel Lin wrote:
> Codec output pin should be defined with SND_SOC_DAPM_OUTPUT.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> Note:
> Just found this bug while reading the code.
> I don't have this hardware handy. I appreciate if someone can test it.
>
> Axel
>
The fix does look correct.
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: wm1250-ev1: Define "WM1250 Output" with SND_SOC_DAPM_OUTPUT
2011-05-26 2:54 [PATCH] ASoC: wm1250-ev1: Define "WM1250 Output" with SND_SOC_DAPM_OUTPUT Axel Lin
2011-05-26 11:04 ` Liam Girdwood
@ 2011-05-26 14:18 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-05-26 14:18 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, linux-kernel, Liam Girdwood
On Thu, May 26, 2011 at 10:54:12AM +0800, Axel Lin wrote:
> Codec output pin should be defined with SND_SOC_DAPM_OUTPUT.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-26 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-26 2:54 [PATCH] ASoC: wm1250-ev1: Define "WM1250 Output" with SND_SOC_DAPM_OUTPUT Axel Lin
2011-05-26 11:04 ` Liam Girdwood
2011-05-26 14:18 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).