From: Liam Girdwood <lrg@ti.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH for 2.6.40] ASoC: Fix power down for widgetless per-card DAPM context case
Date: Thu, 26 May 2011 15:38:42 +0100 [thread overview]
Message-ID: <4DDE65F2.1050908@ti.com> (raw)
In-Reply-To: <1306416738-8298-1-git-send-email-jhnikula@gmail.com>
On 26/05/11 14:32, Jarkko Nikula wrote:
> Commit 52ba67b ("ASoC: Force all DAPM contexts into the same bias state")
> powers up all the DAPM contexts in a card if any DAPM context becomes
> active. Unfortunately power down newer happens if per-card DAPM context
> doesn't have any widgets.
>
> Reason for this is that power state of per-card DAPM context without
> widgets is never cleared and thus all the DAPM contexts remain permanently
> active. Test for widgetless calling DAPM context in dapm_power_widgets()
> doesn't work for per-card DAPM context since power change is never
> originating from widgetless per-card DAPM context.
>
> Fix this by pre-clearing power state flag of non-codec DAPM context at the
> beginning of power sequence.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> ---
> sound/soc/soc-dapm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-05-26 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 13:32 [PATCH for 2.6.40] ASoC: Fix power down for widgetless per-card DAPM context case Jarkko Nikula
2011-05-26 14:38 ` Liam Girdwood [this message]
2011-05-26 15:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDE65F2.1050908@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox