From: Liam Girdwood <lrg@ti.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH V2 0/4] Add Samsung internal dma driver support
Date: Thu, 16 Jun 2011 09:34:35 +0100 [thread overview]
Message-ID: <4DF9C01B.5040607@ti.com> (raw)
In-Reply-To: <1308127407-22458-1-git-send-email-sbkim73@samsung.com>
On 15/06/11 09:43, Sangbeom Kim wrote:
> I2S in samsung audio subsytem has a small internal dma(idma).
> IDMA can be used in low power audio mode and I2S0 secondary fifo
> data tranfer.
> In this patchsets, idma driver is added.
> Original code is made by jassi brar on SMDKV210
> After idma driver merge, I will submit low power audio support
> with idma driver and samsung dsp driver.
>
> Changes since v1:
> 1. Change idma_new by new pcm_new api
> 2. Add handling different idma address
> 3. As jassi comments, Modify the idma driver
>
> This patchset contains followings
>
> o To Jassi Brar, Mark Brown and Liam Girdwood,
> [PATCH V2 1/4] ASoC: SAMSUNG: Modify I2S driver to support idma
> [PATCH V2 2/4] ASoC: SAMSUNG: Add I2S0 internal dma driver
Acked-by: Liam Girdwood <lrg@ti.com>
but you have left #define DEBUG enabled in 1/4.
This could be fixed incrementally if you don't have to do a V3 for any other reasons.
Liam
next prev parent reply other threads:[~2011-06-16 8:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 8:43 [PATCH V2 0/4] Add Samsung internal dma driver support Sangbeom Kim
2011-06-15 8:43 ` [PATCH V2 1/4] ASoC: SAMSUNG: Modify I2S driver to support idma Sangbeom Kim
2011-06-18 8:46 ` Jassi Brar
2011-06-15 8:43 ` [PATCH V2 2/4] ASoC: SAMSUNG: Add I2S0 internal dma driver Sangbeom Kim
2011-06-18 8:58 ` Jassi Brar
2011-06-15 8:43 ` [PATCH V2 3/4] ARM: SAMSUNG: Add platform device for idma Sangbeom Kim
2011-06-15 8:43 ` [PATCH V2 4/4] ARM: SAMSUNG: Add IRQ_I2S0 definition Sangbeom Kim
2011-06-16 8:34 ` Liam Girdwood [this message]
2011-07-21 7:53 ` [PATCH V2 0/4] Add Samsung internal dma driver support Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF9C01B.5040607@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassisinghbrar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox